Skip to content

Add pause button for video header #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Add pause button for video header #2819

wants to merge 1 commit into from

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jul 16, 2019 •
edited
Loading

Addresses issue #4594.

@googlebot googlebot added the cla: yes Signed the Google CLA label Jul 16, 2019
@westonruter westonruter mentioned this pull request Jul 16, 2019
Merged
@westonruter
Copy link
Member Author

There is one issue, however: amp-bind is not set up to allow toggling the paused state of an amp-video. Neither is there a togglePlay action exposed on amp-video. There are only play and pause actions. This means that the singular wp-custom-header-video-button will not work as-is in how it toggles pause/play. There will need to be two separate buttons, one for pause and another for play and only one can be shown at a time. For accessibility, we'll need to ensure that focus is put on the alternate button when toggling.

Todo: Raise this with AMP core.

@jauyong jauyong added Size: S Upstream Bug Requires an upstream change from WordPress, Gutenberg, or another dependency. labels Nov 12, 2019
@schlessera schlessera mentioned this pull request Nov 19, 2019
Closed
@schlessera
Copy link
Collaborator

Todo: Raise this with AMP core.

=> ampproject/amphtml#25669

@amedina amedina added Sanitizers and removed Size: S Integration: WP Core On Hold Upstream Bug Requires an upstream change from WordPress, Gutenberg, or another dependency. labels Mar 31, 2020
@westonruter westonruter linked an issue Apr 16, 2020 that may be closed by this pull request
Pause button is missing for video header #4594
Closed
@westonruter westonruter removed a link to an issue Apr 16, 2020
Pause button is missing for video header #4594
Closed
@schlessera schlessera added the WS:Core Work stream for Plugin core label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Signed the Google CLA Sanitizers WS:Core Work stream for Plugin core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@westonruter @schlessera @amedina @swissspidy @googlebot @jauyong