Sh 3985 Daemon Cleanup Pulled Image feature flag (disabled by default) #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
reviewed
Jun 24, 2025
Signed-off-by: houdini91 <mdstrauss91@gmail.com>
4236a4c to
7acfcd5
Compare
Signed-off-by: houdini91 <mdstrauss91@gmail.com>
|
Hey @houdini91 just noting here we will want to make sure this is disabled by default and opt in; I noted in the original issue. |
Signed-off-by: houdini91 <mdstrauss91@gmail.com>
|
@kzantow I've updated the code to reflect your comment. If you prefer a different approach, please let me know. (One unexplored option in this PR was using an environment variable like TMPDIR, perhaps IMAGE_CLEANUP_ENABLE, to keep provider constructors unchanged.)" |
Signed-off-by: houdini91 <mdstrauss91@gmail.com>
|
@kzantow Fixed Lint error |
|
A needed feature when running on CIs or when running to generate sboms at scale |
|
Up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second Suggestion: Cleanup Only when active pull by provider.
See anchore/syft#3985