Set the GGCR user agent #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a feature that's generally encouraged for consumers of GGCR, so that registry vendors can better identify the clients that are using GGCR to talk to registries. Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
|
Ideally you could include both |
|
Happy to include the version reflection logic if the maintainers want it, defer to them on preference. |
|
I think adding the application is a good start. If we're going to add version support that should probably be plumbed in via syft and grype directly (so expose a way to provide that via the API here). |
wagoodman
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature that's generally encouraged for consumers of GGCR, so that registry vendors can better identify the clients that are using GGCR to talk to registries.
cc @luhring