Add a friendly error message when Zig version is too old or too recent #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
While trying to build poop from source, I encountered issues when building with Zig 0.14.1.
It seems a completely expected issue, regarding the rapid evolution of Zig. I've seen that few of the last commits actually keep poop in sync with latest Zig version.
I thought that some
comptimecode imposing bounds on which version of Zig is currently supported would help the user who tries to build from source.I'm quite new to Zig, so there may be plenty of room to write version check in a much factorized way.
I haven't thoroughly tested max and min allowable bounds. For head of master, I can assert that building on
0.14.1is broken. Thus,0.15.0 <= version <= 0.15.0seems reasonable.I would also perfectly understand that this is not at all a good idea to enforce such bounds.
Thank you for all your work on Zig !