Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FragmentStrictMode] Detect calls to Fragment#setUserVisibleHint #136

Closed
wants to merge 2 commits into from
Closed

[FragmentStrictMode] Detect calls to Fragment#setUserVisibleHint #136

wants to merge 2 commits into from

Conversation

simonschiller
Copy link
Contributor

Proposed Changes

  • Detect calls to Fragment#setUserVisibleHint

Testing

Test: See FragmentStrictModeTest#detectSetUserVisibleHint

Issues Fixed

Fixes: 153738974

@dlam
Copy link
Member

dlam commented Mar 4, 2021

Navigation build is broken atm, so please ignore that 😃

@dlam dlam requested a review from jbw0033 March 4, 2021 02:08
@jbw0033
Copy link

jbw0033 commented Mar 10, 2021

Hey, could you rebase this? We uploaded jetifier to ignore this entire directory https://android-review.googlesource.com/c/platform/frameworks/support/+/1622522

@simonschiller
Copy link
Contributor Author

Rebased ✅

@ianhanniballake
Copy link
Member

PS: I forgot to mention how much I really appreciate these PRs @simonschiller. Really excited to see the progression here 💯

@simonschiller simonschiller deleted the feature/set-user-visible-hint branch March 12, 2021 08:02
@simonschiller
Copy link
Contributor Author

Happy to help 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhanniballake ianhanniballake ianhanniballake approved these changes

@jbw0033 jbw0033 jbw0033 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simonschiller @dlam @jbw0033 @ianhanniballake @googlebot