GitHub app scm project alt #15481
Open
GitHub app scm project alt #15481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add github_app_id, github_app_installation_id and github_api_url to scm credential type - Add ability to generate github app token to clone project with git for github
ed5905e to
b58d221
Compare
|
FTR, I think this is not that different from the first PR in that it mistreats the concept of GitHub Apps. It works, but it's more of a PoC hack rather than full integration with the native concepts GH Apps present. |
b58d221 to
633d8ea
Compare
|
9 tasks
arrestle
reviewed
Jan 20, 2025
|
|
||
| github_api_url = credential.get_input('github_api_url', default='https://api.github.com') | ||
| installation_id = credential.get_input('github_app_installation_id', default='') | ||
| url = f'{github_api_url}/app/installations/{installation_id}/access_tokens' |
There was a problem hiding this comment.
We don't have repo yet so we need to use the installation id. We don't get the repository until the playbook runs in
awx/awx/playbooks/project_update.yml
Line 49 in 46403e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Alternative to #15472
IMPORTANT: UI change needed currently UI hard codes to namespace='scm' need to change to kind='scm'
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION