Enhance color scheme and formatting methods #4481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update markup_map with Ansible-consistent color mappings - info: cyan+dim (matches Ansible skip) - warning: magenta+bold (matches Ansible warn) - action: yellow (matches Ansible changed) - scenario: green (matches Ansible OK) - Add comprehensive documentation explaining color alignment strategy - Maintain full backward compatibility with existing markup tags
- Remove level_no parameter, simplify to only use level_name - Use process_markup() with logging.level.* tags for consistency - Update tests to match new signature and Ansible-aligned colors: - DEBUG: dim (gray) - INFO: cyan (matches Ansible skip) - WARNING: magenta (matches Ansible warn) - ERROR: red (matches Ansible error) - All 40 ansi_output tests pass, full backward compatibility maintained
- Add optional step parameter for enhanced scenario formatting - Use process_markup() with [scenario] and [action] tags for consistency - Add RIGHT_ARROW (➜) symbol constant for step separation - Format: '[scenario_name] ➜ [step]:' with colors when step provided - Add comprehensive test for step functionality - All 41 ansi_output tests pass, full backward compatibility maintained
alisonlhart
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the markup system to align with Ansible color conventions and improves consistency across formatting methods.
Changes
Color Scheme Enhancement:
markup_mapwith Ansible-consistent ANSI codesinfo: cyan+dim (matches Ansible skip messages)warning: magenta+bold (matches Ansible warn messages)action: yellow (matches Ansible changed messages)scenario: green (matches Ansible OK messages)API Improvements:
format_log_level(): Removedlevel_noparameter, now usesprocess_markup()withlogging.level.*tagsformat_scenario(): Added optionalstepparameter with RIGHT_ARROW symbol for enhanced displayprocess_markup()for consistent tag processingBackward Compatibility
All changes maintain full backward compatibility. Existing method signatures work unchanged, with new optional parameters providing enhanced functionality.
Testing
Technical Details
Three focused commits implement these changes incrementally, each maintaining test coverage and code quality standards.