Switch Ui codegen to fastAPI spec #42222
Open
+508
−23,008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f2736a
to
ae14c0c
Compare
pierrejeambrun
approved these changes
Sep 16, 2024
Comment on lines
+47
to
+58
| origins = [ | ||
| "http://localhost:28080", | ||
| "http://localhost:8080", | ||
| ] | ||
| app.add_middleware( | ||
| CORSMiddleware, | ||
| allow_origins=origins, | ||
| allow_credentials=True, | ||
| allow_methods=["*"], | ||
| allow_headers=["*"], | ||
| ) | ||
|
|
There was a problem hiding this comment.
I don't know if you want to do that now or merge this one and do that in the following PR but 'packaging' things to plug on the config and remove hardcoded values to make that 'production' ready.
-
axios.defaults.baseURL will not work depending on how they deploy the
airflow fastapi-apiand only works with breeze
I approved just in case you want to move forward and merge that working 'development' environment, we will need to figure things out a bit
There was a problem hiding this comment.
I am on vacation for the next week so feel free to contribute to this PR. Or merge this one and fix the urls in a follow-up PR
ae14c0c
to
1a22044
Compare
vincbeck
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch new UI to use fastAPI
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.