Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-16017: Checkpoint restored offsets instead of written offsets #15044

Merged
merged 8 commits into from
Dec 21, 2023
Merged

KAFKA-16017: Checkpoint restored offsets instead of written offsets #15044

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a28411
KAFKA-16017: Checkpoint restored offsets instead of written offsets
cadonna Dec 18, 2023
a3fb436
Use more meaningful name
cadonna Dec 18, 2023
6be0405
Delete System.outs and try improve robustness of integration test
cadonna Dec 19, 2023
97e4227
Simplify record value and ensure exception is thrown
cadonna Dec 19, 2023
e082655
Fix checkstyle error
cadonna Dec 19, 2023
e69abfb
Ensure partition to verify contains committed records
cadonna Dec 20, 2023
db151a5
Abort the verification for committed records regarding some conditions
cadonna Dec 20, 2023
75ada37
Fix checkstyle issues
cadonna Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix checkstyle issues
  • Loading branch information
@cadonna
cadonna committed Dec 20, 2023
commit 75ada37afe9533be3989d51f023b7ac5708c65cf
2 changes: 1 addition & 1 deletion checkstyle/suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@

<!-- Streams tests -->
<suppress checks="ClassFanOutComplexity"
files="(RecordCollectorTest|StreamsPartitionAssignorTest|StreamThreadTest|StreamTaskTest|TaskManagerTest|TopologyTestDriverTest|KafkaStreamsTest).java"/>
files="(RecordCollectorTest|StreamsPartitionAssignorTest|StreamThreadTest|StreamTaskTest|TaskManagerTest|TopologyTestDriverTest|KafkaStreamsTest|EosIntegrationTest).java"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have probably solved this checkstyle issue by moving the test to a separate file but I think it makes sense to keep it in EosIntegrationTest to avoid starting an additional embedded Kafka.


<suppress checks="MethodLength"
files="(EosIntegrationTest|EosV2UpgradeIntegrationTest|KStreamKStreamJoinTest|RocksDBWindowStoreTest|StreamStreamJoinIntegrationTest).java"/>
Expand Down
4 changes: 2 additions & 2 deletions streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@ private <K, V> void ensureCommittedRecordsInTopicPartition(final String topic,
final int numberOfRecords,
final Class<? extends Deserializer<K>> keyDeserializer,
final Class<? extends Deserializer<V>> valueDeserializer) throws Exception {
final long timeoutMs = 2*DEFAULT_TIMEOUT;
final long timeoutMs = 2 * DEFAULT_TIMEOUT;
final int maxTries = 10;
final long deadline = System.currentTimeMillis() + timeoutMs;
int tries = 0;
Expand All @@ -1210,7 +1210,7 @@ private <K, V> void ensureCommittedRecordsInTopicPartition(final String topic,
timeoutMs
);
++tries;
if(consumerRecords.stream().anyMatch(record -> record.partition() == partition)) {
if (consumerRecords.stream().anyMatch(record -> record.partition() == partition)) {
return;
}
if (tries >= maxTries) {
Expand Down