-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-10199: Remove queue-based remove from state updater #15896
Merged
cadonna
merged 8 commits into
apache:trunk
from
cadonna:stateupdater_stateupdater_remove_queue-based_remove
May 15, 2024
Merged
KAFKA-10199: Remove queue-based remove from state updater #15896
cadonna
merged 8 commits into
apache:trunk
from
cadonna:stateupdater_stateupdater_remove_queue-based_remove
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbru
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
cadonna
force-pushed
the
stateupdater_stateupdater_remove_queue-based_remove
branch
from
May 8, 2024 13:43
a0c6754
to
ab9d4e2
Compare
…ater Uses the new remove operation of the state updater that returns a future to handle task assignment.
Uses the new remove operation of the state updater that returns a future to shutdown the task manager.
Removes the unused remove operation from the state updater that asynchronously removed tasks and put them into an output queue.
cadonna
force-pushed
the
stateupdater_stateupdater_remove_queue-based_remove
branch
from
May 13, 2024 13:38
ab9d4e2
to
d98800e
Compare
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
Removes the unused remove operation from the state updater that asynchronously removed tasks and put them into an output queue. Reviewer: Lucas Brutschy <lbrutschy@confluent.io>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
Removes the unused remove operation from the state updater that asynchronously removed tasks and put them into an output queue. Reviewer: Lucas Brutschy <lbrutschy@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the unused remove operation from the state updater
that asynchronously removed tasks and put them into an
output queue.
Committer Checklist (excluded from commit message)