Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-10199: Remove queue-based remove from state updater #15896

Conversation

cadonna
Copy link
Contributor

@cadonna cadonna commented May 8, 2024

Removes the unused remove operation from the state updater
that asynchronously removed tasks and put them into an
output queue.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@cadonna cadonna requested a review from lucasbru May 8, 2024 11:48
Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cadonna cadonna force-pushed the stateupdater_stateupdater_remove_queue-based_remove branch from a0c6754 to ab9d4e2 Compare May 8, 2024 13:43
cadonna and others added 7 commits May 13, 2024 14:35
…ater

Uses the new remove operation of the state updater that returns
a future to handle task assignment.
Uses the new remove operation of the state updater that returns
a future to shutdown the task manager.
Removes the unused remove operation from the state updater
that asynchronously removed tasks and put them into an
output queue.
@cadonna cadonna force-pushed the stateupdater_stateupdater_remove_queue-based_remove branch from ab9d4e2 to d98800e Compare May 13, 2024 13:38
@cadonna cadonna merged commit d2e6c86 into apache:trunk May 15, 2024
1 check failed
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
Removes the unused remove operation from the state updater
that asynchronously removed tasks and put them into an
output queue.

Reviewer: Lucas Brutschy <lbrutschy@confluent.io>
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
Removes the unused remove operation from the state updater
that asynchronously removed tasks and put them into an
output queue.

Reviewer: Lucas Brutschy <lbrutschy@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants