Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/arm64: add have fork config #14648

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

lipengfei28
Copy link
Contributor

1.ARCH_ARM64 select ARCH_HAVE_FORK

Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

@github-actions github-actions bot added the Size: XS The size of the change in this PR is very small label Nov 5, 2024
@pussuw
Copy link
Contributor

pussuw commented Nov 5, 2024

I'm pretty sure ostest will crash with arm64 kernel mode.

@xiaoxiang781216
Copy link
Contributor

I'm pretty sure ostest will crash with arm64 kernel mode.

Yes, the current implementation of fork/vfork is only for flat/protected build, the kernel mode need be reimplemented like Linux, which is a huge task I think that.

@pussuw
Copy link
Contributor

pussuw commented Nov 5, 2024

I'm pretty sure ostest will crash with arm64 kernel mode.

Yes, the current implementation of fork/vfork is only for flat/protected build, the kernel mode need be reimplemented like Linux, which is a huge task I think that.

I mean arm64 vfork() will cause ostest crash in kernel mode, making the test unusable in arm64.
I did the fix for risc-v, it could be backported to this platform too ?

@xiaoxiang781216
Copy link
Contributor

I'm pretty sure ostest will crash with arm64 kernel mode.

Yes, the current implementation of fork/vfork is only for flat/protected build, the kernel mode need be reimplemented like Linux, which is a huge task I think that.

I mean arm64 vfork() will cause ostest crash in kernel mode, making the test unusable in arm64. I did the fix for risc-v, it could be backported to this platform too ?

how about change to:

	select ARCH_HAVE_FORK if !BUILD_KERNEL

before we port your riscv patch to arm64.

@pussuw
Copy link
Contributor

pussuw commented Nov 6, 2024

I'm pretty sure ostest will crash with arm64 kernel mode.

Yes, the current implementation of fork/vfork is only for flat/protected build, the kernel mode need be reimplemented like Linux, which is a huge task I think that.

I mean arm64 vfork() will cause ostest crash in kernel mode, making the test unusable in arm64. I did the fix for risc-v, it could be backported to this platform too ?

how about change to:

	select ARCH_HAVE_FORK if !BUILD_KERNEL

before we port your riscv patch to arm64.

Sounds good to me

Signed-off-by: lipengfei28 <lipengfei28@xiaomi.com>
@lupyuen
Copy link
Member

lupyuen commented Nov 7, 2024

Sorry I have to cancel the CI Check, there's a problem with CI Test:

@xiaoxiang781216 xiaoxiang781216 merged commit e292583 into apache:master Nov 7, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants