Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile/build: Delete unnecessary bin and kbin folders #14696

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Nov 8, 2024

Summary

  1. Calling CLEAN on these folders did not have any effect
  2. bin,kbin will be created during the context construction process

Impact

None

Testing

None

@github-actions github-actions bot added Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Nov 8, 2024
@github-actions github-actions bot added the Area: Memory Management Memory Management issues label Nov 8, 2024
@W-M-R W-M-R changed the title libc: Delete unnecessary bin and kbin folders makefile/build: Delete unnecessary bin and kbin folders Nov 8, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 8, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements. While it attempts to address the summary section, it lacks crucial information:

  • Missing Explanation of Necessity: It states what isn't working, but not why the change is necessary. What problem does this solve? Why are bin and kbin not being cleaned? Why should they be created during context construction?
  • Missing Technical Details: It mentions what is being changed (creation of bin, kbin during context construction) but not how. What code is being modified? What is the context construction process?
  • Missing Issue References: Are there any related issues in the NuttX or NuttX Apps repositories?
  • Impact Section Too Brief: Even if there is no user, build, hardware, documentation, security, or compatibility impact, the PR submitter should explicitly state "NO" for each item and briefly justify why (e.g., "Impact on user: NO - This is an internal change to the build system"). "None" is too ambiguous.
  • Testing Section Inadequate: "None" is unacceptable. The PR description must include testing information. Even if the change is small, there should be some evidence that it works as intended. What was tested? What were the results? Empty log sections are not helpful.

The submitter needs to significantly revise the PR description to provide the missing details and demonstrate that the change has been properly tested.

@W-M-R W-M-R changed the title makefile/build: Delete unnecessary bin and kbin folders libc/build: Delete unnecessary bin and kbin folders Nov 8, 2024
@github-actions github-actions bot removed the Area: Memory Management Memory Management issues label Nov 8, 2024
@github-actions github-actions bot added the Area: Memory Management Memory Management issues label Nov 8, 2024
@W-M-R W-M-R force-pushed the libc branch 2 times, most recently from 8d4ffb8 to bb04d33 Compare November 8, 2024 08:50
@W-M-R W-M-R changed the title libc/build: Delete unnecessary bin and kbin folders makefile/build: Delete unnecessary bin and kbin folders Nov 8, 2024
@W-M-R W-M-R force-pushed the libc branch 2 times, most recently from 660e678 to 671358c Compare November 8, 2024 15:58
1. Calling CLEAN on these folders did not have any effect
2. bin,kbin will be created during the context construction process

Signed-off-by: wangmingrong1 <wangmingrong1@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 6dd3139 into apache:master Nov 9, 2024
27 checks passed
@W-M-R W-M-R deleted the libc branch November 11, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build system Area: Memory Management Memory Management issues Area: OS Components OS Components issues Area: Tooling Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants