Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch: use up_current_regs/up_set_current_regs replace CURRENT_REGS #13423

Merged
merged 1 commit into from
Sep 13, 2024
Merged

arch: use up_current_regs/up_set_current_regs replace CURRENT_REGS #13423

merged 1 commit into from
Sep 13, 2024

Conversation

hujun260
Copy link
Contributor

@hujun260 hujun260 commented Sep 13, 2024 •
edited
Loading

Summary

reason:
1 On different architectures, we can utilize more optimized strategies
to implement up_current_regs/up_set_current_regs.
eg. use interrupt registers or percpu registers.

code size
before
text data bss dec hex filename
262848 49985 63893 376726 5bf96 nuttx

after
text data bss dec hex filename
262844 49985 63893 376722 5bf92 nuttx

size change -4

Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic
-machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx

Impact

none

Testing

ostest

@hujun260
arch: use up_current_regs/up_set_current_regs replace CURRENT_REGS
18d0599 
reason:
1 On different architectures, we can utilize more optimized strategies
  to implement up_current_regs/up_set_current_regs.
eg. use interrupt registersor percpu registers.

code size
before
    text    data     bss     dec     hex filename
 262848   49985   63893  376726   5bf96 nuttx

after
       text    data     bss     dec     hex filename
 262844   49985   63893  376722   5bf92 nuttx

size change -4

Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic \
   -machine virt,virtualization=on,gic-version=3 \
   -net none -chardev stdio,id=con,mux=on -serial chardev:con \
   -mon chardev=con,mode=readline -kernel ./nuttx

Signed-off-by: hujun5 <hujun5@xiaomi.com>
GUIDINGLI
GUIDINGLI approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@GUIDINGLI GUIDINGLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of are replacement, LGTM

@xiaoxiang781216 xiaoxiang781216 merged commit 908df72 into apache:master Sep 13, 2024
28 checks passed
@tmedicci
Copy link
Contributor

Hi @hujun260 ,

This PR broke esp32s3-devkit:stack: the device halts during bring-up. Can you take a look, please?

It seems that @anjiahao1 made some changes for this same feature in #13457, but I don't know if it was supposed to fix something broke by this PR.

@hujun260
Copy link
Contributor Author

My patch has nothing to do with @anjiahao1's patch.
Thank you for your feedback, but I'm not sure how to reproduce the issue you've reported.
I've reviewed the code again and found that the changes specific to xtensa (esp32s3-devkit:stack) are quite limited,
focusing mainly on the following files, which are mostly simple replacements.
It doesn't seem these changes would cause any issues. Could you please try debugging by rolling back the changes step by step on your own?
I think this debugging is simple.

arch/xtensa/include/irq.h
arch/xtensa/src/common/xtensa.h
arch/xtensa/src/common/xtensa_assert.c
arch/xtensa/src/common/xtensa_backtrace.c
arch/xtensa/src/common/xtensa_cpupause.c
arch/xtensa/src/common/xtensa_initialize.c
arch/xtensa/src/common/xtensa_irqdispatch.c
arch/xtensa/src/common/xtensa_registerdump.c
arch/xtensa/src/common/xtensa_schedsigaction.c

@tmedicci tmedicci mentioned this pull request Sep 20, 2024
Merged
@anchao anchao mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GUIDINGLI GUIDINGLI GUIDINGLI approved these changes

@acassis acassis acassis approved these changes

@anchao anchao Awaiting requested review from anchao

@masayuki2009 masayuki2009 Awaiting requested review from masayuki2009

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hujun260 @tmedicci @acassis @GUIDINGLI @xiaoxiang781216