Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build depend:Revert Make.dep intermediate ddc file #13455

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

xuxin930
Copy link
Contributor

Summary

Revert "Parallelize depend file generation"
This reverts #2335

parallel depend ddc does not significantly speed up compilation,
intermediately generated .ddc files can cause problems if compilation is interrupted unexpectedly

Impact

Testing

Revert "Parallelize depend file generation"
This reverts commit d5b6ec4.

parallel depend ddc does not significantly speed up compilation,
intermediately generated .ddc files can cause problems if compilation is interrupted unexpectedly

Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit ddc3119 into apache:master Sep 15, 2024
28 checks passed
@masayuki2009
Copy link
Contributor

@xuxin930 @xiaoxiang781216
How did you test this PR?
I noticed this PR causes slow parallel build.

qemu-intel64:nsh, make -j8

Without this PR.

real	0m9.053s
user	0m41.556s
sys	0m14.239s

With this PR

real	0m28.358s
user	0m45.616s
sys	0m16.295s

@masayuki2009
Copy link
Contributor

I noticed this PR causes slow parallel build.

Let me revert this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants