Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

armv7-a gic related update #13466

Merged
merged 6 commits into from
Sep 16, 2024
Merged

armv7-a gic related update #13466

merged 6 commits into from
Sep 16, 2024

Conversation

GUIDINGLI
Copy link
Contributor

Summary

armv7-a/r gic related update

    arm_gicv2: cpu 0 wait other cpu gic init done
    
    After move the SGI irq to group1, other cpu can't response the
    sgi request from cpu0 when its gic not initialized.
    So let cpu0 wait until all other cpus gic initialize done.

    armv7-a/r: check gic init wait done when using sgi
    
    In SMP mode, qemu/goldfish platform, cpu0 use up_cpu_start()
    to start others cpus.
    
    But in previous patch(mathion ahead), arm_gic_initialize() will
    wait others cpus start, so deadlocked!
    
    Resolve:
    Move the wait logic when use using sgi

Impact

armv7a gic

Testing

bes board & qemu

GUIDINGLI and others added 6 commits September 14, 2024 20:59
@GUIDINGLI
armv7-a/r: set up_cpu_start() to wakefunction
6e0bd98 
cause some platform will have their special way

Signed-off-by: ligd <liguiding1@xiaomi.com>
@GUIDINGLI
armv7-a/r: export __start symbol
2650cce 
Signed-off-by: ligd <liguiding1@xiaomi.com>
@CV-Bowen @GUIDINGLI
arm_gicv2: cpu 0 wait other cpu gic init done
e11e3a4 
After move the SGI irq to group1, other cpu can't response the
sgi request from cpu0 when its gic not initialized.
So let cpu0 wait until all other cpus gic initialize done.

Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
@CV-Bowen @GUIDINGLI
arm_gicv2: always enable GIC_ICCICRS_ACKTCTL
d3325a1 
Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
@GUIDINGLI
armv7-a/r: check gic init wait done when using sgi
22bcc2c 
In SMP mode, qemu/goldfish platform, cpu0 use up_cpu_start()
to start others cpus.

But in previous patch(mathion ahead), arm_gic_initialize() will
wait others cpus start, so deadlocked!

Resolve:
Move the wait logic when use using sgi

Signed-off-by: ligd <liguiding1@xiaomi.com>
@hujun260 @GUIDINGLI
gicv2:g_gic_init_done need to be protect
6d9bffd 
Signed-off-by: hujun5 <hujun5@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit c16fd8c into apache:master Sep 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acassis acassis acassis approved these changes

@lupyuen lupyuen lupyuen approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GUIDINGLI @acassis @lupyuen @xiaoxiang781216 @CV-Bowen @hujun260