Skip to content

Conversation

dtengeri
Copy link
Contributor

@dtengeri dtengeri commented Mar 7, 2024

Context:

At the moment if you click on the image it will be opened in full screen, by pushing a new route to the navigator stack. If the WidgetZoom widget is disposed the full screen image remains visible.

Added a property so we can configure this behaviour and made it available to pop the route if the widget is disposed.

Copy link
Contributor

@bernat-gomez bernat-gomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIcely done David, moreover having retrocompat with previous version through the flag.
LGTM

Copy link
Contributor

@khanmujeeb687 khanmujeeb687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bilalhamud bilalhamud merged commit 2b13f21 into main Mar 11, 2024
@bilalhamud bilalhamud deleted the widget_zoom_dispose branch March 11, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants