Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Collapse invisible widgets Field for Auto-height #20142

Merged
merged 10 commits into from
Jan 27, 2023
Merged

feat: Collapse invisible widgets Field for Auto-height #20142

merged 10 commits into from
Jan 27, 2023

Conversation

NilanshBansal
Copy link
Contributor

@NilanshBansal NilanshBansal commented Jan 27, 2023 •
edited
Loading

Description

This PR implements the backend APIs for Invisible widgets in Auto-height containers. It adds a new field collapseInvisibleWidgets which is set to True by default, when creating a new application.
Notion doc here: https://www.notion.so/appsmith/Invisible-widgets-in-auto-height-containers-460c6bf4e0a342e4a1fa4955f7f6c461
Frontend feature implementation here: #20118

Fixes #19983

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual
  • JUnit

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Jan 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
appsmith ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 3:58PM (UTC)

@github-actions github-actions bot added Auto Height Issues related to dynamic height of widgets Enhancement New feature or request UI Building Product Issues related to the UI Building experience labels Jan 27, 2023
@NilanshBansal NilanshBansal marked this pull request as draft January 27, 2023 08:14
@NilanshBansal NilanshBansal marked this pull request as ready for review January 27, 2023 08:18
@NilanshBansal
Copy link
Contributor Author

/ok-to-test sha=6aad876055cb210f8ed83d996a55a4bbc82a927a

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4022726929.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6aad876055cb210f8ed83d996a55a4bbc82a927a.
PR: 20142.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20142&runId=4022726929_1

@NilanshBansal NilanshBansal enabled auto-merge (squash) January 27, 2023 08:20
@NilanshBansal
Copy link
Contributor Author

/ok-to-test sha=02bdf31b1eecaecee96744e0f54828f0b33596d8

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4023855391.
Workflow: Appsmith External Integration Test Workflow.
Commit: 02bdf31b1eecaecee96744e0f54828f0b33596d8.
PR: 20142.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20142&runId=4023855391_1

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4023899592.
Workflow: Appsmith External Integration Test Workflow.
Commit: 02bdf31b1eecaecee96744e0f54828f0b33596d8.
PR: 20142.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20142&runId=4023899592_1

@github-actions
Copy link

The following are new failures, please fix them before merging the PR

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Custom_Chart_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup2_spec.js

@github-actions
Copy link

The following are new failures, please fix them before merging the PR

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/Application/ReconnectDatasource_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_InputWidget_Table_Sorting_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/TableV2_ClientSide_Search_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Table_ClientSide_Search_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/DatasourceSchema_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/JSParse_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Entity_Naming_conflict_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Pages_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Canvas_Context_Selected_Widgets_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/FirstTimeUserOnboarding_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EmptyCanvas_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Custom_Chart_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FormProperties_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_UnicodeKeys_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List1_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Multiselect/MultiSelect2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/MapChart_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/Video_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Select/Select_TreeSelect_MultiSelect_OnFocus_OnBlur_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Sliders/NumberSlider_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Tab/Tab_new_scenario_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Button_Icon_validation_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_MultiRowSelect_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Inline_editing_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_IconName_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/checkboxCell_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/inline_editing_validations_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Bugs_Spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/Datasources/ElasticSearchDatasource_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/Datasources/SMTPDatasource_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js

@github-actions
Copy link

The following are new failures, please fix them before merging the PR

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/Application/ReconnectDatasource_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_InputWidget_Table_Sorting_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/TableV2_ClientSide_Search_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Table_ClientSide_Search_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/JSParse_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Entity_Naming_conflict_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Pages_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Canvas_Context_Selected_Widgets_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/FirstTimeUserOnboarding_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EmptyCanvas_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Custom_Chart_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FormProperties_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_UnicodeKeys_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List1_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Multiselect/MultiSelect2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/MapChart_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/Video_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Select/Select_TreeSelect_MultiSelect_OnFocus_OnBlur_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Sliders/NumberSlider_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Tab/Tab_new_scenario_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Button_Icon_validation_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_MultiRowSelect_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Inline_editing_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_IconName_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/checkboxCell_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/inline_editing_validations_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Bugs_Spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/Datasources/ElasticSearchDatasource_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/Datasources/SMTPDatasource_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js

@github-actions
Copy link

The following are new failures, please fix them before merging the PR

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/Application/ReconnectDatasource_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Bind_InputWidget_Table_Sorting_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/TableV2_ClientSide_Search_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Binding/Table_ClientSide_Search_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AbortAction_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/JSParse_Spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Entity_Naming_conflict_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Entity_Explorer_Query_Datasource_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Pages_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Canvas_Context_Selected_Widgets_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/IDE/MaintainContext&Focus_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/FirstTimeUserOnboarding_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EmptyCanvas_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Custom_Chart_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Checkbox/CheckboxGroup2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FormProperties_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_UnicodeKeys_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/List/List1_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Multiselect/MultiSelect2_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/MapChart_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/Video_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Select/Select_TreeSelect_MultiSelect_OnFocus_OnBlur_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Sliders/NumberSlider_spec.ts
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Tab/Tab_new_scenario_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_Button_Icon_validation_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV1/Table_MultiRowSelect_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Inline_editing_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_PropertyPane_IconName_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/columnTypes/checkboxCell_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/inline_editing_validations_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_Bugs_Spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/Datasources/ElasticSearchDatasource_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/Datasources/SMTPDatasource_spec.js
cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts
cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js

@NilanshBansal
Copy link
Contributor Author

/ok-to-test sha=161c0032269cd5618b722823a8cf39c31369571d

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4026051613.
Workflow: Appsmith External Integration Test Workflow.
Commit: 161c0032269cd5618b722823a8cf39c31369571d.
PR: 20142.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=20142&runId=4026051613_1

@github-actions
Copy link

The following are new failures, please fix them before merging the PR

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js
cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js

@NilanshBansal NilanshBansal merged commit ad2c9c0 into release Jan 27, 2023
@NilanshBansal NilanshBansal deleted the feature/collapseInvisibleWidgets branch January 27, 2023 17:43
@NilanshBansal NilanshBansal added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riodeuno riodeuno riodeuno left review comments

@sumitsum sumitsum sumitsum approved these changes

@vishnu-gp vishnu-gp Awaiting requested review from vishnu-gp

Assignees
No one assigned
Labels
Auto Height Issues related to dynamic height of widgets Enhancement New feature or request skip-changelog Adding this label to a PR prevents it from being listed in the changelog UI Building Product Issues related to the UI Building experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Collapse all invisible widgets in view and preview mode
3 participants
@NilanshBansal @riodeuno @sumitsum