Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use spring-security native CSRF protection #33180

Closed
wants to merge 9 commits into from
Closed

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented May 5, 2024

  • Add the token to Login form.
  • Add the token to Signup form.
  • Get token added to login form, after a logout.

/ok-to-test tags="@tag.Sanity"

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8965354124
Commit: 1510914
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Sanity/Datasources/ArangoDataSourceStub_spec.js
  2. cypress/e2e/Sanity/Datasources/Arango_Basic_Spec.ts
  3. cypress/e2e/Sanity/Datasources/AuthenticatedApiDatasource_spec.js
  4. cypress/e2e/Sanity/Datasources/AuthenticatedApiWithOAuth_spec.ts
  5. cypress/e2e/Sanity/Datasources/DSAutosaveImprovements_spec.ts
  6. cypress/e2e/Sanity/Datasources/DatasourceForm_spec.js
  7. cypress/e2e/Sanity/Datasources/ElasticSearchDatasource_spec.js
  8. cypress/e2e/Sanity/Datasources/GraphQL_spec.ts
  9. cypress/e2e/Sanity/Datasources/MongoDatasourceURI_spec.ts
  10. cypress/e2e/Sanity/Datasources/MySQLDataSourceStub_spec.js
  11. cypress/e2e/Sanity/Datasources/MySQLNoiseTest_spec.js
  12. cypress/e2e/Sanity/Datasources/MySQL_spec.js
  13. cypress/e2e/Sanity/Datasources/Port_Number_Placeholder_Spec.ts
  14. cypress/e2e/Sanity/Datasources/PostgresDatasource_spec.js
  15. cypress/e2e/Sanity/Datasources/RedshiftDataSourceStub_spec.js
  16. cypress/e2e/Sanity/Datasources/RestApiDatasource_spec.js
  17. cypress/e2e/Sanity/Datasources/RestApiOAuth2Validation_spec.ts
  18. cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js
  19. cypress/e2e/Sanity/Datasources/Styles_spec.js
To know the list of identified flaky tests - Refer here

@sharat87 sharat87 changed the title chore/csrf chore: Use spring-security native CSRF protection May 5, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 5, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot May 6, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot May 6, 2024
@sharat87 sharat87 added the ok-to-test Required label for CI label May 6, 2024
@github-actions github-actions bot added the Stale label May 13, 2024
@github-actions github-actions bot closed this May 20, 2024
@sharat87 sharat87 reopened this Jun 5, 2024
@sharat87 sharat87 removed the Stale label Jun 5, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot Jun 5, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot Jun 5, 2024
Copy link
Contributor

coderabbitai bot commented Jun 20, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sharat87 sharat87 closed this Nov 8, 2024
@sharat87 sharat87 deleted the chore/csrf branch November 8, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant