-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CollectionsByCategory): collections ordering #11040
feat(CollectionsByCategory): collections ordering #11040
Conversation
collectionID: card.entityID, | ||
contextModule: section.contextModule as ContextModule, | ||
index, | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this now using the wrong analytics event? Not all section instances of type HomeViewSectionCardChips are guaranteed to represent a grouping of Marketing Collections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Louis from @artsy/data-platform asked to change it to the tappedCollectionGroup event, gonna pass the ⚽ to him
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR were slimmed down to just the CURATED
sort change, I think we could merge it right away but I want to chat with Louis about the event before changing the analytics here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DiscoverSomethingNew rail seems like a rail of collections, rather than cards!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
e392b74
to
477a92c
Compare
Description
Passes some sorting CURATED to MP to receive the collections in the right order.
Extra: adjust Discover Something new event tracking to use tappedCollectionGroupSimulator.Screen.Recording.-.iPhone.14.Pro.-.2024-10-30.at.14.44.39.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.