feat(CollectionsByCategory): collections ordering #11040
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egdbear
previously approved these changes
Oct 30, 2024
dblandin
requested changes
Oct 30, 2024
| collectionID: card.entityID, | ||
| contextModule: section.contextModule as ContextModule, | ||
| index, | ||
| }) |
There was a problem hiding this comment.
Isn't this now using the wrong analytics event? Not all section instances of type HomeViewSectionCardChips are guaranteed to represent a grouping of Marketing Collections.
There was a problem hiding this comment.
Louis from @artsy/data-platform asked to change it to the tappedCollectionGroup event, gonna pass the ⚽ to him
There was a problem hiding this comment.
If this PR were slimmed down to just the CURATED sort change, I think we could merge it right away but I want to chat with Louis about the event before changing the analytics here.
There was a problem hiding this comment.
The DiscoverSomethingNew rail seems like a rail of collections, rather than cards!
e392b74
to
477a92c
Compare
damassi
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Passes some sorting CURATED to MP to receive the collections in the right order.
Extra: adjust Discover Something new event tracking to use tappedCollectionGroupSimulator.Screen.Recording.-.iPhone.14.Pro.-.2024-10-30.at.14.44.39.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.