Add windows clang to CI #5537
Add windows clang to CI #5537
Conversation
kimkulling
commented
Apr 9, 2024
- Add windows clang build step
- Help to evaluate assimp is not compiled with clang #5519
- Add windows clang build step - Help to evaluate #5519
- Build the viewer onl< with msvc
Disable warning.
Fix compiler warning
test/unit/utIOStreamBuffer.cpp
Outdated
| @@ -86,7 +84,7 @@ TEST_F( IOStreamBufferTest, open_close_Test ) { | |||
| const auto dataCount = dataSize / sizeof(*data); | |||
|
|
|||
| char fname[]={ "octest.XXXXXX" }; | |||
| auto* fs = MakeTmpFile(fname); | |||
| FILE *fsm = fopen(fname, "w+"); | |||
There was a problem hiding this comment.
This is not even remotely correct. MakeTmpFile securely creates a file which did not exist previously.
There was a problem hiding this comment.
Right!It was a test to see if this will influence the failing unittest somehow. Any ideas what is going wrong there?
There was a problem hiding this comment.
The fopen thing? That's MS braindeadedness, just add _CRT_SECURE_NO_WARNINGS preprocessor macro somewhere in CMakelists.txt
There was a problem hiding this comment.
No, the failed unittest with the error code 127 when opening the tempfile.
There was a problem hiding this comment.
Looks like it assumes that MSVC is the same as win32 and GCC/clang isn't.
assimp/test/unit/UnitTestFileGenerator.h
Line 53 in f636252
|