Receipt: Improve data display #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor immediate visual nit, let's reduce the bottom/top padding between the cards to maybe half (if 16 total ->, if 8 ->4) of what it is now. Looks great though - will give it a proper review this evening! |
|
ping @dstrukt |
Once more an improvement for the receipt, which also fixes btcpayserver#5882: - Unify data displayed on the web and print version - Split cart and additional data and ensure additional data is displayed - Do not display extra subtotal row if there are no tips or discounts - Make PosData partial more universal and backwards-compatible by using case insensitive key lookups
dstrukt
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
tACK - great improvements @dennisreimann! could only find that original nit - excited to see this carry over to the app
|
Regarding the nit: that would make it different from the spacings we use elsewhere. Imho we should adapt it everywhere to stay consistent and file a separate issue for that. |
NicolasDorier
pushed a commit
that referenced
this pull request
May 23, 2024
Once more an improvement for the receipt, which also fixes #5882: - Unify data displayed on the web and print version - Split cart and additional data and ensure additional data is displayed - Do not display extra subtotal row if there are no tips or discounts - Make PosData partial more universal and backwards-compatible by using case insensitive key lookups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once more an improvement for the receipt, which also fixes #5882: