Skip to content

Do not synthesize discarded events #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 4, 2024
Merged

Do not synthesize discarded events #2108

merged 10 commits into from
Dec 4, 2024

Conversation

YYChen01988
Copy link
Contributor

Goal

Discard event should not be synthesize.

Changeset

Added a DiscardEventCallback before ExitInfoCallback so the discarded event would not be synthesized.

Testing

Existing tests

@YYChen01988 YYChen01988 requested a review from lemnik November 19, 2024 15:15
@YYChen01988 YYChen01988 force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch from 64ba4cb to 3818ac2 Compare November 19, 2024 15:17
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Nov 19, 2024 •
edited
Loading

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1871.53 1675.95
arm64_v8a 647.43 450.82
armeabi_v7a 585.99 385.29
x86 725.23 528.62
x86_64 692.47 495.86

Generated by 🚫 Danger

@YYChen01988 YYChen01988 force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch 2 times, most recently from 6aa898c to 58cb07a Compare November 19, 2024 15:55
@YYChen01988 YYChen01988 force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch from 58cb07a to c9d9126 Compare November 19, 2024 15:57
@YYChen01988 YYChen01988 force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch 2 times, most recently from ccdd5a5 to a0377f2 Compare November 21, 2024 09:31
@lemnik
Merge pull request #2110 from bugsnag/lemnik/mazerunner-mappingtxt
8862708 
Include the mapping.txt file in the published end2end test artifacts
@YYChen01988 YYChen01988 force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch 3 times, most recently from ffdf7b7 to e0bec01 Compare November 21, 2024 12:05
@lemnik lemnik force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch 13 times, most recently from f27b055 to a1d71a4 Compare November 26, 2024 10:49
@lemnik lemnik force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch from a1d71a4 to 22596dd Compare November 26, 2024 11:24
@YYChen01988 @lemnik
feat(exitinfo): remove the unmatched native crash reporting and turn …
cbb566d 
…off the unmatched ANR handling by default to avoid unexpected behaviour in upgrades
@lemnik lemnik force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch from 22596dd to cbb566d Compare November 26, 2024 11:30
@lemnik lemnik changed the title not to synthesize discarded events Do not synthesize discarded events Nov 26, 2024
@lemnik lemnik force-pushed the PLAT-13027/do-not-synthesize-discarded-events branch from e8a300b to 6437989 Compare November 26, 2024 15:05
@YYChen01988 YYChen01988 merged commit 33e64d1 into integration/synthesise-ANR-and-native-crash-reports Dec 4, 2024
52 checks passed
@YYChen01988 YYChen01988 deleted the PLAT-13027/do-not-synthesize-discarded-events branch December 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YYChen01988 @bugsnagbot @lemnik @Cawllec