Added the ability to specify codeset switches manually in a Code128 barcode. #1
Conversation
… the CODE128CUSTOM type
…e128 constructor for CUSTOM
…ion of barcode for Custom and Dynamic to correctly switch
|
explain to me the business need for this custom C128 encoding so I understand what is going on here before I pull this. |
|
also when pulling into another repo consolidating multiple commits into one commit would be nice to keep the history neater looking. |
|
Do you want to fix this pull request so I can merge it in or do you want me to close it? |
| return new Code128CustomBuilder() | ||
| { | ||
| Code128String = | ||
| string.Format("{0}{1}{2}{3}", Code128String, char.ConvertFromUtf32(140), type.ToString(), barcodePart) |
There was a problem hiding this comment.
@bbarnhill I think that wrapping on lines 14–17 is just what VS automatically does. No point in trying to override VS because whenever you edit near that it’ll just reperform that same whitespace change again.
Line 25 is so long maybe it needs to be split up more ;-).
There was a problem hiding this comment.
I think its probably fine in length ... just wrapped for some reason
|
Can one of the admins verify this patch? |
|
Final ask before I close this ... does someone want to get this ready for merger or should it just be closed? |
| @@ -89,6 +89,7 @@ | |||
| <Compile Include="Symbologies\Codabar.cs" /> | |||
| <Compile Include="Symbologies\Code11.cs" /> | |||
| <Compile Include="Symbologies\Code128.cs" /> | |||
| <Compile Include="Symbologies\Code128CustomBuilder.cs" /> | |||
There was a problem hiding this comment.
I think Custom can be removed from this title since its really just building a Code128 string to be encoded.
No description provided.