Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Warning message is not displayed when trying to open excellentmovies.net from URL bar #3367

Closed
luixxiul opened this issue Aug 24, 2016 · 4 comments · Fixed by #3411
Closed

Warning message is not displayed when trying to open excellentmovies.net from URL bar #3367

luixxiul opened this issue Aug 24, 2016 · 4 comments · Fixed by #3411
Assignees
@bridiver
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.11.6dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 24, 2016 •
edited
Loading

Describe the issue you encountered:
When I was trying to open excellentmovies.net from URL bar by hitting a enter key, it did not display the warning message. If I hit the key again, it was displayed.

Expected behavior: The warning message should be displayed with a single enter key

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 7 64 bit
  • Brave Version: 0.11.6 beta3
  • Steps to reproduce:
    1. Copy this url: excellentmovies.net
    2. Move away your session-store-1 file temporarily
    3. Open browser
    4. Paste the url into the URL bar
    5. Hit Enter -> nothing is displayed
    6. Hit it again -> warning message is displayed
  • Screenshot if needed:
  • Any related issues: Manual tests for Win-x64 0.11.6 beta3 #3362
@luixxiul
Copy link
Contributor Author

Confirmed on Windows 10 32 bit too #3363

@luixxiul luixxiul mentioned this issue Aug 24, 2016
Closed
@luixxiul luixxiul added this to the 0.11.6dev milestone Aug 24, 2016
@luixxiul
Copy link
Contributor Author

Setting a milestone for now

@luixxiul luixxiul changed the title Warning message is not displayed when trying to open excellentmovies.net Warning message is not displayed when trying to open excellentmovies.net from URL bar Aug 24, 2016
@bbondy
Copy link
Member

bbondy commented Aug 25, 2016

cc @bridiver or @diracdeltas I reproduced this too

@bridiver
Copy link
Collaborator

this is similar to #3354
we're trying to match a url that hasn't been set yet in the frame. We somehow lost tabId in the web request, but I'm going to add it back in so we can route to the correct webContents

bridiver added a commit that referenced this issue Aug 25, 2016
@bridiver
route safebrowsing and httpse messages by tabId
a5cbbd1 
fixes #3367
requires brave/muon@a6046ca
@bridiver bridiver mentioned this issue Aug 25, 2016
Merged
3 tasks
bridiver added a commit that referenced this issue Aug 25, 2016
@bridiver
route safebrowsing and httpse messages by tabId
a12cac4 
fixes #3367
requires brave/muon@a6046ca
@bridiver bridiver self-assigned this Aug 25, 2016
This was referenced Aug 25, 2016
Closed
Closed
This was referenced Aug 25, 2016
Closed
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Aug 31, 2016
Closed
@alexwykoff alexwykoff mentioned this issue Aug 31, 2016
Closed
@aekeus aekeus mentioned this issue Aug 31, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.11.6dev
Development

Successfully merging a pull request may close this issue.

route safebrowsing and httpse messages by tabId brave/browser-laptop
4 participants
@bridiver @bbondy @alexwykoff @luixxiul