Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: drop redundant zlib var, rename function (internals) #14918

Closed
wants to merge 2 commits into from
Closed

cmake: drop redundant zlib var, rename function (internals) #14918

wants to merge 2 commits into from
+4 −6

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 15, 2024 •
edited
Loading

  • drop redundant internal variable USE_ZLIB, rely on HAVE_LIBZ.

  • rename optional_dependency() → curl_dependency_option()
    Make grep 'option(' hit this option. Namespaced.
    It has a single use with ZLIB.

@github-actions github-actions bot added the build label Sep 15, 2024
@vszakats vszakats closed this in abf737b Sep 19, 2024
@vszakats vszakats deleted the cm-zlib-tidy branch September 19, 2024 11:03
moritzbuhl pushed a commit to moritzbuhl/curl that referenced this pull request Sep 20, 2024
@vszakats @moritzbuhl
cmake: drop redundant zlib var, rename function (internals)
950b039 
- drop redundant internal variable `USE_ZLIB`, rely on `HAVE_LIBZ`.

- rename `optional_dependency()` -> `curl_dependency_option()`
  Make `grep 'option('` hit this option. Namespaced.
  It has a single use with `ZLIB`.

Closes curl#14918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build cmake tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vszakats