deps: update to dmn-js@16.7.1 #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's make sure we also update camunda/camunda-dmn-js. |
|
|
Oops, this works in the literal expression but not in the BKM view: Screen.Recording.2024-09-19.at.16.43.20.mov |
|
Likely this is related to https://stackoverflow.com/questions/46997189/why-height-100-doesnt-work |
|
Let's create a relevant follow-up for BKM. I'm merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4342
Proposed Changes
Make literal expression editor take full height of its container, effectively allowing text area to focus when clicking anywhere on the editor, not only on the text lines.
Screen.Recording.2024-09-18.at.15.14.56.mov
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}