Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Try harder to determine FMT_VERSION #1478

Merged
merged 1 commit into from
Jul 2, 2024
Merged

build: Try harder to determine FMT_VERSION #1478

merged 1 commit into from
Jul 2, 2024

Conversation

hhoffstaette
Copy link
Contributor

@hhoffstaette hhoffstaette commented Jul 2, 2024 •
edited
Loading

fmt-11.0 moved FMT_VERSION from core.h to base.h, so try the new header first and then fall back to the old one. Tested against fmt-9.1, 10.2.1, 11.0.

Closes: #1477

@jrosdahl jrosdahl added bug Does not work as intended/documented build Affects building of Ccache itself labels Jul 2, 2024
jrosdahl
jrosdahl reviewed Jul 2, 2024
View reviewed changes
cmake/FindFmt.cmake Outdated Show resolved Hide resolved
@jrosdahl jrosdahl added this to the 4.10.2 milestone Jul 2, 2024
@hhoffstaette
build: Try harder to determine FMT_VERSION
db136b6 
fmt-11.0 moved the FMT_VERSION from core.h to base.h, so try the
new header first and then fall back to the old one.

Closes: #1477
@jrosdahl jrosdahl merged commit 71f772e into ccache:master Jul 2, 2024
44 checks passed
@jrosdahl
Copy link
Member

jrosdahl commented Jul 2, 2024

Thanks.

jrosdahl pushed a commit that referenced this pull request Jul 2, 2024
@hhoffstaette @jrosdahl
build: Try harder to determine FMT_VERSION (#1478)
83190ff 
fmt-11.0 moved the FMT_VERSION from core.h to base.h, so try the
new header first and then fall back to the old one.

Closes: #1477
(cherry picked from commit 71f772e)
@hhoffstaette hhoffstaette deleted the fmt-11 branch July 2, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrosdahl jrosdahl jrosdahl left review comments

Assignees
No one assigned
Labels
bug Does not work as intended/documented build Affects building of Ccache itself
Projects
None yet
Milestone
4.10.2
Development

Successfully merging this pull request may close these issues.

Configuration failure with fmt-11.0 due to movement of FMT_VERSION
2 participants
@hhoffstaette @jrosdahl