Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use bash for running script command #1482

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: use bash for running script command #1482

merged 1 commit into from
Jul 9, 2024

Conversation

afbjorklund
Copy link
Contributor

The script program will try to run the --command parameter with the login shell,
rather than the currently running test shell (bash).

So if your login shell is set to a csh variant instead of a sh variant, you will get syntax errors from CCACHE_DIR=$CCACHE_DIR

Just set SHELL=$BASH:

ENVIRONMENT
       The following environment variable is utilized by script:

       SHELL  If  the variable SHELL exists, the shell forked by script will be that shell.  If SHELL is not set, the
              Bourne shell is assumed.  (Most shells set this variable automatically).

@afbjorklund
fix: use bash for running script command
ca0d60e 
The script program will try to run the --command parameter with the
login shell, rather than the currently running test shell (bash).
@jrosdahl jrosdahl added portability Affects portability of building or using Ccache test Affects testing of Ccache itself labels Jul 9, 2024
@jrosdahl jrosdahl added this to the 4.10.2 milestone Jul 9, 2024
@jrosdahl jrosdahl merged commit 18c44ca into ccache:master Jul 9, 2024
42 checks passed
@jrosdahl
Copy link
Member

jrosdahl commented Jul 9, 2024

Thanks.

jrosdahl pushed a commit that referenced this pull request Jul 22, 2024
@afbjorklund @jrosdahl
test: Use bash for running script command (#1482)
4304769 
The script program will try to run the --command parameter with the
login shell, rather than the currently running test shell (bash).

(cherry picked from commit 18c44ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
portability Affects portability of building or using Ccache test Affects testing of Ccache itself
Projects
None yet
Milestone
4.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@afbjorklund @jrosdahl