fix(binance) - minor fix #23659
Open
fix(binance) - minor fix #23659
+7
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttodua
commented
Sep 6, 2024
| @@ -747,6 +746,7 @@ export default class binance extends Exchange { | |||
| 'income/asyn/id': 5, | |||
| 'pmExchangeInfo': 0.5, // Weight(IP): 5 => cost = 0.1 * 5 = 0.5 | |||
| 'pmAccountInfo': 0.5, // Weight(IP): 5 => cost = 0.1 * 5 = 0.5 | |||
| 'historicalTrades': 20, | |||
There was a problem hiding this comment.
this endpoint in dapi, is private, not public:
https://dapi.binance.com/dapi/v1/historicalTrades
so, i've moved it from dapiPublic -> dapiPrivate
ttodua
commented
Sep 6, 2024
| @@ -894,9 +894,6 @@ export default class binance extends Exchange { | |||
| 'positionRisk': 1, | |||
| }, | |||
| }, | |||
| 'fapiPublicV3': { | |||
| 'get': {}, | |||
| }, | |||
There was a problem hiding this comment.
fapiPublicv3 was empty, needed to be removed.
ttodua
commented
Sep 6, 2024
| }, | ||
| 'delete': { | ||
| 'userDataStream': 0.4, | ||
| }, |
There was a problem hiding this comment.
userDataStream might need to be private: https://github.com/binance/binance-spot-api-docs/blob/master/rest-api.md#user-data-stream-endpoints
also the code suggests so, see this:
Lines 11186 to 11199 in bb2675e
all other market types (sapi, fapi etc..) also have userDataStream endpoint under private
ttodua
commented
Sep 6, 2024
| @@ -854,6 +853,7 @@ export default class binance extends Exchange { | |||
| 'feeBurn': 1, | |||
| 'symbolConfig': 5, | |||
| 'accountConfig': 5, | |||
| 'historicalTrades': 20, | |||
There was a problem hiding this comment.
same for fapi: https://fapi.binance.com/fapi/v1/historicalTrades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.