Add absolute humidity calculation in g/m³ #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add absolute_humidity_g_m3() function to conv.py using Magnus-Tetens approximation - Export humidity_abs field in both InfluxDB and MQTT outputs - Update README Home Assistant integration with absolute humidity sensor - Calculation uses temperature (°C) and relative humidity (%) from Aranet sensor Co-Authored-By: Chris Dzombak <chris@dzombak.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Wrap long function calls across multiple lines in influx.py and mqtt.py - Addresses CI lint failure in PR #7 Co-Authored-By: Chris Dzombak <chris@dzombak.com>
cdzombak
requested changes
Jul 20, 2025
| return mbar * 0.02952998751 | ||
|
|
||
|
|
||
| def absolute_humidity_g_m3(temp_celsius: float, relative_humidity_pct: float) -> float: |
There was a problem hiding this comment.
Please add some test cases for this function that are easily human-readable for a quick sanity check.
- Add comprehensive docstring with human-readable test cases - Include typical room conditions, cold conditions, and warm humid examples - Addresses GitHub comment requesting sanity check examples Co-Authored-By: Chris Dzombak <chris@dzombak.com>
- Remove trailing whitespace from docstring - Addresses CI lint failure after adding test cases Co-Authored-By: Chris Dzombak <chris@dzombak.com>
cdzombak
requested changes
Jul 20, 2025
| Test cases for quick sanity check: | ||
| 20°C, 60% RH → 10.37 g/m³ (typical room conditions) | ||
| 0°C, 50% RH → 2.42 g/m³ (cold conditions) | ||
| 25°C, 80% RH → 18.42 g/m³ (warm, humid conditions) |
There was a problem hiding this comment.
Add standard Python unit tests for these cases.
- Create test_conv.py with unittest framework - Test all three documented test cases with proper assertions - Addresses GitHub comment requesting standard Python unit tests - All tests pass locally Co-Authored-By: Chris Dzombak <chris@dzombak.com>
- Apply Ruff formatting to test_conv.py - Addresses CI lint failure after adding unit tests - All tests continue to pass locally Co-Authored-By: Chris Dzombak <chris@dzombak.com>
cdzombak
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add absolute humidity calculation in g/m³
Summary
Adds absolute humidity calculation to Aranet4 sensor readings, exported alongside existing sensor values in both InfluxDB and MQTT outputs. The implementation uses the Magnus-Tetens approximation to calculate absolute humidity in g/m³ from temperature (°C) and relative humidity (%) readings.
Key Changes:
absolute_humidity_g_m3()function inconv.pyusing standard meteorological formulahumidity_absfield in both InfluxDB and MQTT data streamsReview & Testing Checklist for Human
AH = (6.112 × e^[(17.67 × T)/(T+243.5)] × rh × 2.1674)/(273.15+T)humidity_absfield appears correctly in InfluxDB with reasonable valueshumidity_absfield is present in MQTT messages and matches InfluxDB valuesRecommended test plan: Run the application with
--printflag and verify the new absolute humidity values appear reasonable across different temperature/humidity conditions. Check both InfluxDB and MQTT outputs contain the new field.Diagram
%%{ init : { "theme" : "default" }}%% graph TD A["main.py"]:::context --> B["aranet.py"]:::context B --> C["conv.py"]:::major-edit A --> D["influx.py"]:::major-edit A --> E["mqtt.py"]:::major-edit F["README.md"]:::minor-edit C --> |"absolute_humidity_g_m3()"| D C --> |"absolute_humidity_g_m3()"| E D --> |"humidity_abs field"| G["InfluxDB"]:::context E --> |"humidity_abs field"| H["MQTT Broker"]:::context H --> I["Home Assistant"]:::context subgraph Legend L1["Major Edit"]:::major-edit L2["Minor Edit"]:::minor-edit L3["Context/No Edit"]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
humidity_pct,temp_c,pressure_mbar)Link to Devin run: https://app.devin.ai/sessions/0efbf12ab70747d2baeff9d5f30717e5
Requested by: Chris Dzombak (@cdzombak)