Skip to content

♻️ Improve types in analysis export code a bit #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2025
Merged

♻️ Improve types in analysis export code a bit #747

merged 4 commits into from
Oct 10, 2025

Conversation

gwennlbh
Copy link
Member

@gwennlbh gwennlbh commented Oct 9, 2025

  • ♻️ Move MetadataRuntime type definition to a arktype schema
  • 🏷️ Improve typing of analysis export's metadata values

@gwennlbh gwennlbh enabled auto-merge (rebase) October 9, 2025 22:49
@gwennlbh gwennlbh force-pushed the improve_analysis_types branch from c6d5a81 to d86b8ba Compare October 9, 2025 23:14
@gwennlbh gwennlbh force-pushed the improve_analysis_types branch from 2f000fa to 85b177a Compare October 9, 2025 23:34
@gwennlbh gwennlbh force-pushed the improve_analysis_types branch from 85b177a to 4e4405f Compare October 9, 2025 23:36
@gwennlbh gwennlbh temporarily deployed to #747: App preview October 9, 2025 23:36 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
106 45.18 MB → 45.18 MB (+1.24 kB)
11.1 MB → 11.1 MB (gzip)		 +0.00%

Changeset

No files were changed

View detailed bundle breakdown

Added

Asset File Size % Changed
_app/immutable/workers/start-[hash].js 0 B → 1.69 MB (+1.69 MB)
0 B → 574.43 kB (gzip)		 -
_app/immutable/chunks/CWZtwWur.js 0 B → 390.89 kB (+390.89 kB)
0 B → 107.51 kB (gzip)		 -
_app/immutable/chunks/C9ILOAJP.js 0 B → 315.63 kB (+315.63 kB)
0 B → 134.96 kB (gzip)		 -
_app/immutable/chunks/BKZ-zRly.js 0 B → 120.23 kB (+120.23 kB)
0 B → 53.96 kB (gzip)		 -
_app/immutable/chunks/Bk5Noqut.js 0 B → 109.07 kB (+109.07 kB)
0 B → 49.24 kB (gzip)		 -
_app/immutable/nodes/3.CMspKban.js 0 B → 84.51 kB (+84.51 kB)
0 B → 30.12 kB (gzip)		 -
_app/immutable/chunks/BG2CnB0p.js 0 B → 69.57 kB (+69.57 kB)
0 B → 26.13 kB (gzip)		 -
_app/immutable/chunks/B9YIbxps.js 0 B → 54.93 kB (+54.93 kB)
0 B → 26.7 kB (gzip)		 -
_app/immutable/nodes/8.wkWQHtWX.js 0 B → 38.72 kB (+38.72 kB)
0 B → 12.94 kB (gzip)		 -
_app/immutable/nodes/5.-GPYrxZF.js 0 B → 32.92 kB (+32.92 kB)
0 B → 12.97 kB (gzip)		 -
_app/immutable/chunks/-Rkz7nsq.js 0 B → 23.83 kB (+23.83 kB)
0 B → 8.26 kB (gzip)		 -
_app/immutable/nodes/2.D2R-Jh2l.js 0 B → 21.03 kB (+21.03 kB)
0 B → 9.85 kB (gzip)		 -
_app/immutable/chunks/mo5YQbO9.js 0 B → 17.53 kB (+17.53 kB)
0 B → 6.88 kB (gzip)		 -
_app/immutable/chunks/DTjT57mH.js 0 B → 9.09 kB (+9.09 kB)
0 B → 3.65 kB (gzip)		 -
_app/immutable/chunks/B91ejd2F.js 0 B → 6.27 kB (+6.27 kB)
0 B → 3.22 kB (gzip)		 -
_app/immutable/entry/app.BHyTrbsb.js 0 B → 5.83 kB (+5.83 kB)
0 B → 2.22 kB (gzip)		 -
_app/immutable/nodes/12.C98d0z7E.js 0 B → 5.23 kB (+5.23 kB)
0 B → 2.62 kB (gzip)		 -
_app/immutable/chunks/BDckdHlB.js 0 B → 4.86 kB (+4.86 kB)
0 B → 2.31 kB (gzip)		 -
_app/immutable/nodes/6.NpyKiP3L.js 0 B → 4.15 kB (+4.15 kB)
0 B → 1.94 kB (gzip)		 -
_app/immutable/nodes/9.QeGlNrEf.js 0 B → 3.55 kB (+3.55 kB)
0 B → 1.9 kB (gzip)		 -
_app/immutable/nodes/7.370J0_x6.js 0 B → 2.63 kB (+2.63 kB)
0 B → 1.46 kB (gzip)		 -
_app/immutable/chunks/Cm05vucm.js 0 B → 2.17 kB (+2.17 kB)
0 B → 1002 B (gzip)		 -
_app/immutable/nodes/4.DcZW6Gct.js 0 B → 2.01 kB (+2.01 kB)
0 B → 1.03 kB (gzip)		 -
_app/immutable/chunks/aQIhw4kk.js 0 B → 1.97 kB (+1.97 kB)
0 B → 1.18 kB (gzip)		 -
_app/immutable/chunks/CXyrqRxt.js 0 B → 1.05 kB (+1.05 kB)
0 B → 515 B (gzip)		 -
_app/immutable/nodes/1.BWg5TBJ-.js 0 B → 886 B (+886 B)
0 B → 573 B (gzip)		 -
_app/immutable/chunks/DV6imJ--.js 0 B → 839 B (+839 B)
0 B → 533 B (gzip)		 -
_app/immutable/chunks/CNhrWwQk.js 0 B → 746 B (+746 B)
0 B → 465 B (gzip)		 -
_app/immutable/chunks/D8qIzORK.js 0 B → 715 B (+715 B)
0 B → 446 B (gzip)		 -
_app/immutable/chunks/Hjr2KMcQ.js 0 B → 458 B (+458 B)
0 B → 330 B (gzip)		 -
_app/immutable/chunks/DacJMBpa.js 0 B → 371 B (+371 B)
0 B → 242 B (gzip)		 -
_app/immutable/chunks/CsAJpoBF.js 0 B → 210 B (+210 B)
0 B → 170 B (gzip)		 -
_app/immutable/chunks/CC339nhk.js 0 B → 118 B (+118 B)
0 B → 110 B (gzip)		 -
_app/immutable/nodes/10.DJW_mAt7.js 0 B → 112 B (+112 B)
0 B → 122 B (gzip)		 -

Removed

Asset File Size % Changed
_app/immutable/workers/web-worker-[hash].js 1.69 MB → 0 B (-1.69 MB)
573.79 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/D5UGkZcq.js 390.89 kB → 0 B (-390.89 kB)
107.51 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/sesOuys0.js 315.31 kB → 0 B (-315.31 kB)
134.86 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/D-OEC_cv.js 120.23 kB → 0 B (-120.23 kB)
53.96 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/UDpkk12U.js 109.07 kB → 0 B (-109.07 kB)
49.24 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/3.iZUyCA95.js 84.51 kB → 0 B (-84.51 kB)
30.12 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/CU6OAXe1.js 69.49 kB → 0 B (-69.49 kB)
26.07 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/CLVXD19O.js 54.93 kB → 0 B (-54.93 kB)
26.7 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/8.4uZM4I8o.js 38.72 kB → 0 B (-38.72 kB)
12.94 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/5.CHQgfTSa.js 32.92 kB → 0 B (-32.92 kB)
12.97 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/B-Rje9go.js 23.83 kB → 0 B (-23.83 kB)
8.25 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/2.CxY8CHRG.js 21.03 kB → 0 B (-21.03 kB)
9.87 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/CZCXFxHY.js 17.53 kB → 0 B (-17.53 kB)
6.88 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/tmHQX5PX.js 9.09 kB → 0 B (-9.09 kB)
3.65 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/P-dVOX9z.js 6.27 kB → 0 B (-6.27 kB)
3.22 kB → 0 B (gzip)		 -100%
_app/immutable/entry/app.BnGptpzN.js 5.83 kB → 0 B (-5.83 kB)
2.22 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/12.BNUt5XGI.js 5.23 kB → 0 B (-5.23 kB)
2.62 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/Dal1kC2H.js 4.86 kB → 0 B (-4.86 kB)
2.31 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/6.CmbHYx9U.js 4.15 kB → 0 B (-4.15 kB)
1.94 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/9.B9-7rXmq.js 3.55 kB → 0 B (-3.55 kB)
1.9 kB → 0 B (gzip)		 -100%
_app/immutable/nodes/7.BnIx0CeC.js 2.63 kB → 0 B (-2.63 kB)
1.46 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/DyYXX-IN.js 2.17 kB → 0 B (-2.17 kB)
1002 B → 0 B (gzip)		 -100%
_app/immutable/nodes/4.R31X-MDU.js 2.01 kB → 0 B (-2.01 kB)
1.03 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/EoEViE_b.js 1.97 kB → 0 B (-1.97 kB)
1.18 kB → 0 B (gzip)		 -100%
_app/immutable/chunks/D_fK5PSG.js 1.05 kB → 0 B (-1.05 kB)
515 B → 0 B (gzip)		 -100%
_app/immutable/nodes/1._gsmEk4G.js 886 B → 0 B (-886 B)
573 B → 0 B (gzip)		 -100%
_app/immutable/chunks/CWb-5LcM.js 839 B → 0 B (-839 B)
533 B → 0 B (gzip)		 -100%
_app/immutable/chunks/DUM_LIfD.js 746 B → 0 B (-746 B)
465 B → 0 B (gzip)		 -100%
_app/immutable/chunks/CSVrTk0K.js 715 B → 0 B (-715 B)
446 B → 0 B (gzip)		 -100%
_app/immutable/chunks/4O3SNggQ.js 458 B → 0 B (-458 B)
330 B → 0 B (gzip)		 -100%
_app/immutable/chunks/DRjncn1O.js 371 B → 0 B (-371 B)
242 B → 0 B (gzip)		 -100%
_app/immutable/chunks/Cs5W5jCd.js 210 B → 0 B (-210 B)
170 B → 0 B (gzip)		 -100%
_app/immutable/chunks/DAiuGP7k.js 118 B → 0 B (-118 B)
110 B → 0 B (gzip)		 -100%
_app/immutable/nodes/10.ClJc5AP5.js 112 B → 0 B (-112 B)
122 B → 0 B (gzip)		 -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

@gwennlbh gwennlbh temporarily deployed to #747: End-to-end tests report October 9, 2025 23:42 — with GitHub Actions Inactive
@gwennlbh gwennlbh temporarily deployed to #747: App preview October 10, 2025 00:07 — with GitHub Actions Inactive
@gwennlbh gwennlbh temporarily deployed to #747: End-to-end tests report October 10, 2025 00:13 — with GitHub Actions Inactive
@gwennlbh gwennlbh force-pushed the improve_analysis_types branch from 1809e54 to 39c6d04 Compare October 10, 2025 09:22
@gwennlbh gwennlbh temporarily deployed to #747: App preview October 10, 2025 09:22 — with GitHub Actions Inactive
@gwennlbh
🏷️ Improve typing of analysis export's metadata values
03673c2 
specifically, the case where an observation is missing a value for a metadata of the protocol
@gwennlbh
♻️ Split web worker implementations into multiple files, add import a…
a7b96f1 
…liases for src/{locales,worker}
@gwennlbh
✅ Fix export tests
fdae7b7 
My refactor thingy actualy fixed a bug!
@gwennlbh gwennlbh force-pushed the improve_analysis_types branch from 39c6d04 to fdae7b7 Compare October 10, 2025 09:24
@gwennlbh gwennlbh temporarily deployed to #747: App preview October 10, 2025 09:24 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

✅ Coverage is up by 0.28% (from 68.17% to 68.45%)

@gwennlbh gwennlbh merged commit f3eecd7 into main Oct 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gwennlbh