Skip to content

Conversation

shrynx
Copy link
Contributor

@shrynx shrynx commented Mar 15, 2020

added default arguments for decoder/encoder/codec for useDefaults and discriminator

@shrynx
Copy link
Contributor Author

shrynx commented Mar 15, 2020

@travisbrown should i add tests for it ?
Maybe following the same pattern as TransformMemberNamesSuite

@codecov-io
Copy link

codecov-io commented Mar 15, 2020

Codecov Report

Merging #187 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   31.51%   31.51%           
=======================================
  Files           7        7           
  Lines         568      568           
  Branches       35       35           
=======================================
  Hits          179      179           
  Misses        389      389           
Impacted Files Coverage Δ
...n/scala/io/circe/derivation/DerivationMacros.scala 85.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5a43e...f421df0. Read the comment docs.

@travisbrown
Copy link
Member

Thanks for doing this! And a couple of tests would be great—I don't think it needs a lot of detail, just something to ensure it compiles as expected.

@travisbrown
Copy link
Member

Looks good to me. Thanks again.

@shrynx
Copy link
Contributor Author

shrynx commented Mar 16, 2020

great ! 😃
let me know if there is anything left to get it merged/released

@travisbrown travisbrown merged commit c782b7b into circe:master Mar 16, 2020
@travisbrown
Copy link
Member

@shrynx I'll plan to do a release this week but probably won't have time today or tomorrow.

@shrynx shrynx deleted the shrynx/add-overloaded-methods-for-default-args branch March 16, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants