Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for PostgreSQL 12's pg_rewind implementation #6157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leonardoce
Copy link
Contributor

@leonardoce leonardoce commented Nov 22, 2024

Starting with PostgreSQL 13 pg_rewind automatically handles crash recovery before starting, so it is not needed to manually the postmaster after the first invocation of pg_rewind failed.

Leveraging this feature, this patch removes the code that was manually handling the crash recovery process.

Closes: #6156

@leonardoce leonardoce requested a review from a team as a code owner November 22, 2024 14:23
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24 labels Nov 22, 2024
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@leonardoce leonardoce changed the title chore: drop support for pg_rewind as in PostgreSQL 12. chore: drop support for pg_rewind as in PostgreSQL 12 Nov 22, 2024
@leonardoce leonardoce changed the title chore: drop support for pg_rewind as in PostgreSQL 12 chore: drop support for PostgreSQL 12's pg_rewind implementatoin Nov 22, 2024
@leonardoce leonardoce changed the title chore: drop support for PostgreSQL 12's pg_rewind implementatoin chore: drop support for PostgreSQL 12's pg_rewind implementation Nov 22, 2024
@leonardoce
Copy link
Contributor Author

Starting with PostgreSQL 13 pg_rewind automatically handles crash
recovery before starting, so it is not needed to manually the postmaster
after the first invocation of pg_rewind failed.

Leveraging this feature, this patch removes the code that was manually
handling the crash recovery process.

Fix: cloudnative-pg#6156

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.23 release-1.24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore]: Remove the logic to perform a crash recovery before running pg_rewind
3 participants