Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chinese support (Pinyin) #195

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Added Chinese support (Pinyin) #195

merged 1 commit into from
Nov 30, 2017

Conversation

franmomu
Copy link
Contributor

I just cloned #158, rebased and squash the commits

@florianeckerstorfer
Copy link
Member

Since you basically copied the lost from the mentioned script I have to ask what is the license of that code? Or is this list publicly available?

@franmomu
Copy link
Contributor Author

franmomu commented Nov 30, 2017

It is in the commit's message: a3a2f5d:

Based on jifei's PHP class available at: https://github.com/jifei/Pinyin/blob/master/Pinyin.php

(Not sure if it is what you meant)

@florianeckerstorfer
Copy link
Member

What I meant was what is the license of the project? Are we allowed to use the code from this other project here?

@franmomu
Copy link
Contributor Author

I've just written an email to @jifei asking, if there is no answer we could use maybe the chars.csv here

@florianeckerstorfer
Copy link
Member

Thanks, ping me if you've got a response.

@franmomu
Copy link
Contributor Author

franmomu commented Nov 30, 2017

@florianeckerstorfer I've just got a response:

Glad to receive your letter.The code is long time no maintenance, you can use it, it is best to indicate the source.

So, is it enough with the commit comment? or should I add the repository url somewhere else? (I can only think of the SlugifyTest) .

@florianeckerstorfer
Copy link
Member

@franmomu I will add a note to the README. Thanks for the PR.

@florianeckerstorfer florianeckerstorfer merged commit ad2bda3 into cocur:master Nov 30, 2017
@franmomu
Copy link
Contributor Author

You're welcome!

@SuN-80
Copy link
Contributor

SuN-80 commented Oct 15, 2018

@franmomu thanks for cloning #158, not sure what I did wrong in the first place, but I'm glad you made it work. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants