-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Chinese support (Pinyin) #195
Conversation
Based on jifei's PHP class available at: https://github.com/jifei/Pinyin/blob/master/Pinyin.php
Since you basically copied the lost from the mentioned script I have to ask what is the license of that code? Or is this list publicly available? |
It is in the commit's message: a3a2f5d:
(Not sure if it is what you meant) |
What I meant was what is the license of the project? Are we allowed to use the code from this other project here? |
Thanks, ping me if you've got a response. |
@florianeckerstorfer I've just got a response:
So, is it enough with the commit comment? or should I add the repository url somewhere else? (I can only think of the |
@franmomu I will add a note to the README. Thanks for the PR. |
You're welcome! |
I just cloned #158, rebased and squash the commits