Skip to content

Conversation

SchoolGuy
Copy link
Member

Linked Items

Fixes #3953

Description

This PR is adding content to the dummy docstrings that were inserted during the fast-paced progress that I made to achieve the Cloud-Init and Agama enablement in #3293.

Behaviour changes

None

Category

This is related to a:

  • Bugfix
  • Feature
  • Packaging
  • Docs
  • Code Quality
  • Refactoring
  • Miscellaneous

Tests

  • Unit-Tests were created
  • System-Tests were created
  • Code is already covered by Unit-Tests
  • Code is already covered by System-Tests
  • No tests required

@SchoolGuy SchoolGuy added this to the v3.4.0 milestone Oct 9, 2025
@github-actions github-actions bot added the tests label Oct 9, 2025
@SchoolGuy SchoolGuy force-pushed the fix/todo-docstrings branch from 75e3c4c to 1fe06ae Compare October 9, 2025 14:18
@SchoolGuy SchoolGuy moved this from Todo to Pull Requests in Cobbler Server Oct 9, 2025
Copy link

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little nitpicks about being concise in the phrasing. Otherwise looks good and I am very happy that ValueError("TODO") is gone!

@github-project-automation github-project-automation bot moved this from Pull Requests to In Progress in Cobbler Server Oct 9, 2025
@SchoolGuy SchoolGuy moved this from In Progress to Pull Requests in Cobbler Server Oct 9, 2025
Copy link

codacy-production bot commented Oct 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 50.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f2059b7) 16238 10898 67.11%
Head commit (6a14559) 16238 (+0) 10898 (+0) 67.11% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3958) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

@ByteOtter ByteOtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@SchoolGuy
Copy link
Member Author

GitHub hangs on my browser atm. I will wait with merging this one, until I can see the changes that have been made in the Web UI.

@github-project-automation github-project-automation bot moved this from Pull Requests to In Progress in Cobbler Server Oct 9, 2025
@SchoolGuy SchoolGuy force-pushed the fix/todo-docstrings branch from 1fe06ae to 6a14559 Compare October 9, 2025 15:34
@SchoolGuy SchoolGuy merged commit 3a30f3e into main Oct 9, 2025
26 of 39 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cobbler Server Oct 9, 2025
@SchoolGuy SchoolGuy deleted the fix/todo-docstrings branch October 9, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add docstrings that only have TODO as their content
2 participants