-
-
Notifications
You must be signed in to change notification settings - Fork 651
Add content to dummy docstrings #3958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75e3c4c
to
1fe06ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two little nitpicks about being concise in the phrasing. Otherwise looks good and I am very happy that ValueError("TODO")
is gone!
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏼
GitHub hangs on my browser atm. I will wait with merging this one, until I can see the changes that have been made in the Web UI. |
1fe06ae
to
6a14559
Compare
Linked Items
Fixes #3953
Description
This PR is adding content to the dummy docstrings that were inserted during the fast-paced progress that I made to achieve the Cloud-Init and Agama enablement in #3293.
Behaviour changes
None
Category
This is related to a:
Tests