💎 $30 bounty • EinfachHans

Steps to solve:

1. Start working: Comment /attempt #2332 with your implementation plan
2. Submit work: Create a pull request including /claim #2332 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to coollabsio/coolify!

Add a bounty • Share on socials

/attempt #2332

@algora-pbc check this pr @EinfachHans @cmer @wutangpaul @AshKyd

@Anshgrover23 Awesome you tackled this! For the bounty you have to tackle the second point as well, is this possible? 😊

@EinfachHans yes it is possible I will make new commit by today on this issue for second point also

@EinfachHans done with the changes plss check

@Anshgrover23 your commit doesn't look like what i described in this issue 🤔

@EinfachHans i dont understand i have done what is told in the issue that is i have created a notification function when the health status of a container changes and changes docker-compose services timeout period which you have mentioned in point 2

@EinfachHans am i wrong and where plss tell?

@Anshgrover23 In your second commit you only add whitespaces. Please see description of this issue about point 2. It's about the current health check implementation and to change it to not await the start period. Everything is described in the issue.

Also i would recommend not to ping anyone to review the pr. Whenever there is time andras will review it i guess 😊

@EinfachHans sorry for making spam tagging everywhere and i have changed two docker compose.yml file you can see in my latest commit and i have made health check implementation. and kindly can u please check for me all this and then plss reply back if u can ? iam waiting for your review

@EinfachHans i want to understand where i am lagging off

Again: Please see the original issue description. I paste it here again, i think it is quite clear:

Adjust the start period to work as in docker healthchecks

Start period provides initialization time for containers that need time to bootstrap. Probe failure during that period will not be counted towards the maximum number of retries. However, if a health check succeeds during the start period, the container is considered started and all consecutive failures will be counted towards the maximum number of retries.

From https://stackoverflow.com/a/53290016

I'm sadly not a php developer, but i would say this should be quite easy:

Here instead of sleeping, the current date should be saved and then here, if the current time is still within the saved start date + the startPeriod, don't increase the counter and maybe log an information about it.

@EinfachHans ok i understand now i am working on this now sorry for the inconvenience

@EinfachHans check i have made a new commit and complete the instrcutions given in description and sorry for any misunderstanding.

Is this still needed?

@Wuemeli yes