Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling error, fix would break stats "API" #80

Closed
paravoid opened this issue Feb 18, 2014 · 1 comment
Closed

Spelling error, fix would break stats "API" #80

paravoid opened this issue Feb 18, 2014 · 1 comment
Labels
bug
Milestone
API v2

Comments

@paravoid
Copy link
Contributor

From the pedantic department: the source tree has a number of "commited" (one t) instead of the right "committed". While this would be an easy s/// to fix, one of the spots that is broken is the "commited_offset" field in the stats JSON, which I guess has the same gurantees as ABI by now :)

Maybe we should fix all the spots but this one and document it as part of SONAME 2.0 changes in #66?

(this made me think of HTTP's Referer :))
@edenhill edenhill added the bug label Feb 18, 2014
@edenhill edenhill added this to the API v2 milestone Feb 18, 2014
@edenhill
Copy link
Contributor

Ouch, there are some words I just cant splel!

I could add the correct fieldname along side the wrong one for now and then remove the wrong one with SONAME 2?

@edenhill edenhill modified the milestones: 0.8.4, API v2 Feb 22, 2014
edenhill added a commit that referenced this issue Mar 26, 2014
@edenhill
Added redundant but correctly spelled "committed_offset" field to sta…
fc1ae62 
…ts (issue #80)

Old field, "commited_offset" remains in place until next API version
paravoid added a commit that referenced this issue Apr 7, 2016
@paravoid
Fix spelling issue, s/commited/committed/
47f2955 
See #80.
@ctrochalakis ctrochalakis mentioned this issue Sep 3, 2018
Merged
@MockingJayWong MockingJayWong mentioned this issue Jul 9, 2019
Closed
7 tasks
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
API v2
Development

No branches or pull requests
2 participants
@edenhill @paravoid