Allow for calling rd_kafka_queue_io_event_enable() from the C++ world #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
Oct 23, 2017
src-cpp/rdkafkacpp.h
Outdated
| @@ -1428,6 +1428,8 @@ class RD_EXPORT Queue { | |||
| */ | |||
| virtual int poll (int timeout_ms) = 0; | |||
|
|
|||
| virtual void io_event_enable (int fd, const void *payload, size_t size) = 0; | |||
There was a problem hiding this comment.
Need a doc string here. Copy (and reformat) the one from rdkafka.h
src-cpp/rdkafkacpp.h
Outdated
| @@ -1428,6 +1428,8 @@ class RD_EXPORT Queue { | |||
| */ | |||
| virtual int poll (int timeout_ms) = 0; | |||
|
|
|||
| virtual void io_event_enable (int fd, const void *payload, size_t size) = 0; | |||
There was a problem hiding this comment.
Move this declaration to the end of the class for ABI stability
|
Thank you very much for the feedback. This is my first PR so I hope I've done things correctly. |
edenhill
approved these changes
Oct 23, 2017
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As discussed in, #617, I've created a pull request. Awaiting feedback.
Thanks,
Akhi