Store offset commit metadata when calling rd_kafka_offsets_store
#4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @emasab |
|
Hey folks, |
There's no CHANGELOG yet for the release.
milindl
reviewed
Jan 25, 2023
| "Retrieving committed offsets to verify committed offset " | ||
| "metadata\n"); | ||
| rd_kafka_topic_partition_list_t *committed_toppar; | ||
| committed_toppar = rd_kafka_topic_partition_list_new(1); |
There was a problem hiding this comment.
This needs to be destroyed at the end of the test, rd_kafka_topic_partition_list_destroy(committed_toppar);
There was a problem hiding this comment.
Good catch! Fixed this in 5d37ab1.
|
@mathispesch Thanks for the contribution! For security reason currently it's not allowed to run SemaphoreCI on forked PRs. I merge it into an internal branch and open a new PR. If you want to do additional changes before merging to master please open a new PR based on that branch. |
7 tasks
|
@mathispesch @emasab should it also store metadata when using |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3927.
Offset commit metadata can be used to send additional data to the broker when making an offset commit. See this doc from the Java consumer.
Librdkafka currently sends the offset commit metadata when the commit is requested by calling
rd_kafka_commit_queuebut not when callingrd_kafka_offsets_storeto use the auto-commit. This PR fixes that by storing the offset commit metadata when callingrd_kafka_offsets_store.