Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A NULL coordinator shouldn't be fatal #4020

Merged
merged 6 commits into from
Nov 4, 2022

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Oct 17, 2022

When a PID epoch bump is requested and the producer is waiting
to reconnect to the transaction coordinator, a failure in a find coordinator
request could cause txn_curr_coord to be set to NULL and an assert to fail.
This was fixed by retrying when the coordinator is known.

if an failed FindCoordinatorRequest sets txn
coordinator to NULL just after it reconnects.
@emasab emasab force-pushed the bugfix/idempotent-assertion-current-coordinator branch from aa8a036 to 6c6e108 Compare October 17, 2022 17:36
@emasab emasab marked this pull request as ready for review October 17, 2022 17:36
@emasab emasab force-pushed the bugfix/idempotent-assertion-current-coordinator branch from 6c6e108 to 5099f4f Compare October 17, 2022 17:49
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, some minor changes needed

tests/0105-transactions_mock.c Outdated Show resolved Hide resolved
tests/0105-transactions_mock.c Outdated Show resolved Hide resolved
tests/0105-transactions_mock.c Outdated Show resolved Hide resolved
tests/0105-transactions_mock.c Outdated Show resolved Hide resolved
tests/0105-transactions_mock.c Outdated Show resolved Hide resolved
tests/0105-transactions_mock.c Outdated Show resolved Hide resolved
the fatal error rd_kafka_idemp_pid_fsm: Assertion
`rk->rk_eos.txn_curr_coord' failed
@emasab emasab force-pushed the bugfix/idempotent-assertion-current-coordinator branch from 5099f4f to b8b5864 Compare October 19, 2022 11:54
Copy link
Contributor

@edenhill edenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LgTM!

@edenhill edenhill merged commit e98340b into master Nov 4, 2022
@edenhill edenhill deleted the bugfix/idempotent-assertion-current-coordinator branch November 4, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants