-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A NULL coordinator shouldn't be fatal #4020
Merged
edenhill
merged 6 commits into
master
from
bugfix/idempotent-assertion-current-coordinator
Nov 4, 2022
Merged
A NULL coordinator shouldn't be fatal #4020
edenhill
merged 6 commits into
master
from
bugfix/idempotent-assertion-current-coordinator
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if an failed FindCoordinatorRequest sets txn coordinator to NULL just after it reconnects.
emasab
force-pushed
the
bugfix/idempotent-assertion-current-coordinator
branch
from
October 17, 2022 17:36
aa8a036
to
6c6e108
Compare
emasab
force-pushed
the
bugfix/idempotent-assertion-current-coordinator
branch
from
October 17, 2022 17:49
6c6e108
to
5099f4f
Compare
edenhill
suggested changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, some minor changes needed
the fatal error rd_kafka_idemp_pid_fsm: Assertion `rk->rk_eos.txn_curr_coord' failed
emasab
force-pushed
the
bugfix/idempotent-assertion-current-coordinator
branch
from
October 19, 2022 11:54
5099f4f
to
b8b5864
Compare
edenhill
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LgTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a PID epoch bump is requested and the producer is waiting
to reconnect to the transaction coordinator, a failure in a find coordinator
request could cause txn_curr_coord to be set to NULL and an assert to fail.
This was fixed by retrying when the coordinator is known.