Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added topic id to describe_topic response. #4451

Merged
merged 11 commits into from
Oct 16, 2023
Merged

Added topic id to describe_topic response. #4451

merged 11 commits into from
Oct 16, 2023

Conversation

pranavrth
Copy link
Member

No description provided.

@pranavrth pranavrth force-pushed the dev_add-topic-id-to-describe-topics-response branch from 6ba532e to 5892f68 Compare October 9, 2023 19:49
emasab
emasab requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Just some changes for internal things

src/rdkafka.h Outdated Show resolved Hide resolved
src/rdkafka.h Outdated Show resolved Hide resolved
src/rdkafka_admin.h Outdated Show resolved Hide resolved
src/rdbase64.c Show resolved Hide resolved
src/rdkafka_admin.c Outdated Show resolved Hide resolved
src/rdkafka_admin.c Outdated Show resolved Hide resolved
src/rdkafka_admin.c Outdated Show resolved Hide resolved
src/rdkafka_admin.c Outdated Show resolved Hide resolved
src/rdkafka_admin.c Outdated Show resolved Hide resolved
src/rdkafka.c Outdated Show resolved Hide resolved
@pranavrth pranavrth force-pushed the dev_add-topic-id-to-describe-topics-response branch from f886055 to 762b2c5 Compare October 11, 2023 06:10
emasab
emasab approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Going to merge it once the pipeline run completes

@emasab emasab merged commit 59f3ea3 into master Oct 16, 2023
2 checks passed
@emasab emasab deleted the dev_add-topic-id-to-describe-topics-response branch October 16, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavrth @emasab