-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for an undesired partition migration with stale leader epoch #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 8, 2024 19:09
f13b6d2
to
2779b09
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 11, 2024 09:18
ced675f
to
74b82fc
Compare
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 11, 2024 09:19
2779b09
to
4b005f0
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 11, 2024 17:17
74b82fc
to
05c2830
Compare
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 11, 2024 17:17
4b005f0
to
b9e2442
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 14, 2024 11:03
05c2830
to
8090e71
Compare
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 14, 2024 11:04
b9e2442
to
fd0238d
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 15, 2024 08:06
8090e71
to
bdccc8c
Compare
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 15, 2024 08:07
fd0238d
to
3c7d054
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 15, 2024 09:32
bdccc8c
to
f0d63ab
Compare
7 tasks
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 15, 2024 09:41
3c7d054
to
f3972d1
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 15, 2024 09:44
f0d63ab
to
f9b1fa7
Compare
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 15, 2024 09:45
f3972d1
to
cd88a71
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 15, 2024 10:10
f9b1fa7
to
7bfe82b
Compare
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 15, 2024 10:11
cd88a71
to
addd3d7
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 15, 2024 14:51
7bfe82b
to
e3bc31e
Compare
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 15, 2024 14:51
addd3d7
to
1411693
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
April 15, 2024 15:26
e3bc31e
to
44dc011
Compare
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
2 times, most recently
from
April 15, 2024 17:24
b605960
to
7e06fa5
Compare
Base automatically changed from
dev_fix_metadata_fast_refresh_loop
to
dev_kip848
April 15, 2024 17:56
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 15, 2024 18:02
7e06fa5
to
92eb02b
Compare
with stale leader epoch A partition migration could happen, using stale metadata, when the partition was undergoing a validation and being retried because of an error. Solved by doing a partition migration only with a non-stale leader epoch. Happening since 2.1.0
emasab
force-pushed
the
dev_fix_undesired_partition_migration
branch
from
April 17, 2024 17:49
92eb02b
to
d56573d
Compare
milindl
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the test too
emasab
added a commit
that referenced
this pull request
Apr 18, 2024
A partition migration could happen, using stale metadata, when the partition was undergoing a validation and being retried because of an error. Solved by doing a partition migration only with a non-stale leader epoch. Happening since 2.1.0
anchitj
pushed a commit
that referenced
this pull request
Jun 10, 2024
A partition migration could happen, using stale metadata, when the partition was undergoing a validation and being retried because of an error. Solved by doing a partition migration only with a non-stale leader epoch. Happening since 2.1.0
7 tasks
kphelps
added a commit
to kphelps/librdkafka
that referenced
this pull request
Oct 10, 2024
…och (confluentinc#4680)" This reverts commit 6584ed7.
kphelps
added a commit
to DataDog/librdkafka
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partition migration could happen,
using stale metadata, when the partition
was undergoing a validation and
being retried because of an error.
Solved by doing a partition migration
only with a non-stale leader epoch.
Happening since 2.1.0