Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files for lz4 1.9.4 #4726

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Add files for lz4 1.9.4 #4726

merged 6 commits into from
Jun 6, 2024
+2,191 −1,788

Conversation

milindl
Copy link
Contributor

@milindl milindl commented May 22, 2024

Updates lz4 from 1.9.3 -> 1.9.4

Process:

  • clean copy of all the lz4* files from 1.9.4 checkout of lz4 into the librdkafka src directory
  • copy of xxhash files into rdxxhash files in the same way
  • change any refs to xxhash within lz4* files into rdxxhash
  • Update changelog and licenses, and configure file
  • Run 0017 (compression test)

@milindl milindl requested a review from a team May 22, 2024 05:12
emasab
emasab reviewed Jun 4, 2024
View reviewed changes
src/lz4.c
# define ALLOC(s) lz4_error_memory_allocation_is_disabled
# define ALLOC_AND_ZERO(s) lz4_error_memory_allocation_is_disabled
# define FREEMEM(p) lz4_error_memory_allocation_is_disabled
#elif defined(LZ4_USER_MEMORY_FUNCTIONS)
Copy link
Collaborator

@emasab emasab Jun 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous version 1.9.3 had this part of the code changed to use rd_kafka_mem_malloc ,.... let's keep the same and add a comment to do that when upgrading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this and added upgrade instructions for future developers.

@milindl milindl requested a review from a team as a code owner June 6, 2024 05:59
@milindl milindl requested a review from emasab June 6, 2024 06:01
pranavrth
pranavrth approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.!

@milindl milindl merged commit 2fe647b into master Jun 6, 2024
2 checks passed
@milindl milindl deleted the dev_update_lz4_1.9.4 branch June 6, 2024 11:26
@janjwerner-confluent janjwerner-confluent mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavrth pranavrth pranavrth approved these changes

@emasab emasab Awaiting requested review from emasab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milindl @emasab @pranavrth