enabled query name and type as part of the metrics optionally #7197
+72
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of this change, we are introducing a new configuration for the `forward` plugin named `qtype_for_metrics` that can be used to configure the query types that needs to be generated into metrics which contains the additional information of `name` and `type`. The new metrics will be `request_duration_seconds_with_name` and will contain `"proxy_name", "to", "rcode", "name", "type"` as the labels/tags in the metrics. Signed-off-by: Harsha Narayana <harshnar@cisco.com>
6fbb257 to
75ab279
Compare
|
Hello. I'm not a maintainer, but I have a couple of thoughts on this. Here you add "name" (DNS domain name) as a label to the metric. In this case, each unique DNS query will be a separate row in I don't think this is a good idea. It will cause performance issues on the CoreDNS and metrics collector side. You can read https://prometheus.io/docs/practices/naming/#labels CAUTION for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
As part of this change, we are introducing a new configuration for the
forwardplugin namedqtype_for_metricsthat can be used to configure the query types that needs to be generated into metrics which contains the additional information ofnameandtype.The new metrics will be
request_duration_seconds_with_nameand will contain"proxy_name", "to", "rcode", "name", "type"as the labels/tags in the metrics.2. Which issues (if any) are related?
#7196
3. Which documentation changes (if any) need to be made?
forwardplugin needs to be updated to contain the additional details. https://github.com/coredns/coredns.io/blob/master/content/plugins/forward.md4. Does this introduce a backward incompatible change or deprecation?
No