std::is_literal_type リテラル型についての表現をよりわかりやすく #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
たしかに修正前の文章はへんですね。 |
|
対応しました |
faithandbrave
approved these changes
Jan 6, 2023
|
approvedもらってるので(selfですが)マージしちゃいます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原文は
ですが，ここで "that is not a copy or move constructor" (や直前の "
constexpr")がかかるのは "constructor template" ではなく "constructor or constructor template" なのではないかと思っていて(というのも，コピーコンストラクタやムーヴコンストラクタはコンストラクタテンプレートになりえないので)，そうであればこちらの方がより意図が一意になりそう(元の記述だと「集成体 orconstexprコンストラクタ or コピー/ムーヴでないコンストラクタテンプレート」と解釈されうる)上記の英文解釈が正しいかについてレビューをお願いしたいです