container_exec: fix terminal true process json #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
@mrunalp PTAL |
|
we need this for 1.7 and 1.8 as well. |
|
/test all |
This was referenced Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca runcom@redhat.com
- What I did
Fixed and refactored the way we're calling runc exec in container_exec. This patch is fixing a bug where kube requests the terminal for exec but we're not honoring it.
- How I did it
set terminal in runc exec's process json
- How to verify it
run
kubectl exec -ti POD -- shand see it works, Before this patch, it would just hang.- Description for the changelog