Skip to content

Conversation

umohnani8
Copy link
Member

Bump up version to 1.14.12 for a new release.

Signed-off-by: Urvashi Mohnani umohnani@redhat.com

Bump up version to 1.14.12 for a new release.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@umohnani8
Copy link
Member Author

@haircommander @vrothberg PTAL

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2020

// Version is the version of the build.
const Version = "1.14.11"
const Version = "1.14.13-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we stopped using -dev because of the automation scripts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that so? I saw we were still using dev in 1.15. Will remove it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think we should drop dev everywhere (1.15 was probably an oversight because its our forgotten child)

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #3223 into release-1.14 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.14    #3223   +/-   ##
=============================================
  Coverage         30.82%   30.82%           
=============================================
  Files                78       78           
  Lines              7114     7114           
=============================================
  Hits               2193     2193           
  Misses             4772     4772           
  Partials            149      149

@haircommander
Copy link
Member

/retest

@haircommander
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Feb 6, 2020
@haircommander
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 234cf38 into cri-o:release-1.14 Feb 6, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2020

@umohnani8: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 7f19b5f link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@umohnani8 umohnani8 deleted the 1.14-tag branch February 25, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants