-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[1.14] Bump up version to 1.14.12 #3223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bump up version to 1.14.12 for a new release. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@haircommander @vrothberg PTAL |
version/version.go
Outdated
|
||
// Version is the version of the build. | ||
const Version = "1.14.11" | ||
const Version = "1.14.13-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we stopped using -dev because of the automation scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that so? I saw we were still using dev in 1.15. Will remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think we should drop dev everywhere (1.15 was probably an oversight because its our forgotten child)
Codecov Report
@@ Coverage Diff @@
## release-1.14 #3223 +/- ##
=============================================
Coverage 30.82% 30.82%
=============================================
Files 78 78
Lines 7114 7114
=============================================
Hits 2193 2193
Misses 4772 4772
Partials 149 149 |
/retest |
/lgtm |
/retest |
@umohnani8: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Bump up version to 1.14.12 for a new release.
Signed-off-by: Urvashi Mohnani umohnani@redhat.com