Bump GRPC to v1.27.0 #4190
Merged
Bump GRPC to v1.27.0 #4190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the build of the release-note tool, which previously failed with: ``` vendor/google.golang.org/api/internal/conn_pool.go:29:2: undefined: grpc.ClientConnInterface ``` Signed-off-by: Sascha Grunert <sgrunert@suse.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
|
/test e2e_crun |
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4190 +/- ##
=============================================
Coverage 41.75% 41.75%
=============================================
Files 110 110
Lines 9163 9163
=============================================
Hits 3826 3826
Misses 4994 4994
Partials 343 343 |
|
LGTM |
|
/lgtm thanks @saschagrunert |
This was referenced Nov 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This fixes the build of the release-note tool, which previously failed
with:
Which issue(s) this PR fixes:
Refers to 15aa81b
Unblocks the release after #4188
Special notes for your reviewer:
@haircommander I think we have to re-align the v1.19.0 tag afterwards.
Does this PR introduce a user-facing change?