Skip to content

version: bump to 1.25.4 #7183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

version: bump to 1.25.4 #7183

merged 1 commit into from
Jul 31, 2023

Conversation

sohankunkerkar
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

#6805 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 28, 2023
@openshift-ci openshift-ci bot requested review from klihub and QiWang19 July 28, 2023 14:46
@sohankunkerkar sohankunkerkar marked this pull request as draft July 28, 2023 14:47
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #7183 (541cb21) into release-1.25 (f9ccbe3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.25    #7183   +/-   ##
=============================================
  Coverage         43.60%   43.60%           
=============================================
  Files               122      122           
  Lines             13714    13714           
=============================================
  Hits               5980     5980           
  Misses             7087     7087           
  Partials            647      647

@sohankunkerkar
Copy link
Member Author

I was wondering if we could get #7132 in before merging this PR

@sohankunkerkar
Copy link
Member Author

And #7156 as well

@haircommander
Copy link
Member

let's wait on #7156 but get #7132

@haircommander
Copy link
Member

@sohankunkerkar is this ready?

@sohankunkerkar
Copy link
Member Author

let's wait on #7156 but get #7132

sure thing!

@sohankunkerkar
version: bump to 1.25.4
541cb21 
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
@sohankunkerkar sohankunkerkar marked this pull request as ready for review July 31, 2023 17:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@sohankunkerkar
Copy link
Member Author

@sohankunkerkar is this ready?

Yes, it is

@openshift-ci openshift-ci bot requested a review from wgahnagl July 31, 2023 17:56
@haircommander
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@haircommander
Copy link
Member

/override ci/prow/e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3ad059f into cri-o:release-1.25 Jul 31, 2023
@atirek89
Copy link

atirek89 commented Aug 2, 2023

Is this version released or any ETA on this.

@haircommander
Copy link
Member

https://github.com/cri-o/cri-o/releases/tag/v1.25.4 is released! we'll work on getting packaged this week as well

@agoyald
Copy link

agoyald commented Aug 2, 2023 •
edited
Loading

Thanks for the update.

@sohankunkerkar sohankunkerkar deleted the release-1.25 branch August 2, 2023 18:12
@openshift-ci openshift-ci bot mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sohankunkerkar @haircommander @atirek89 @agoyald @openshift-merge-robot