Build with "tip" version of Golang #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give us early warning of changes in upstream Golang that may affect us. Signed-off-by: Jonathan Yu <jawnsy@redhat.com>
|
LGTM |
|
@runcom Ha, you're too fast for me 😄 I wanted to make sure it was actually building with tip, instead of just "tip" being a symlink for "the latest release" - seems it is! Thanks for the merge! 👍 |
yup I saw that :) thanks @jawnsy |
egernst
pushed a commit
to egernst/cri-o
that referenced
this pull request
Nov 26, 2018
Fixes: cri-o#74 Signed-off-by: Nitesh Konkar niteshkonkar@in.ibm.com
jwcesign
referenced
this pull request
in jwcesign/cri-o
May 1, 2022
bumping knative.dev/hack 9b2ed84...51a42b2: > 51a42b2 Update community files (# 146) > 81ef5cc Update community files (# 145) > cfb3eb8 Enable opting out Preemptible/Spot GKE Worker Nodes (# 144) > 9dd1ec1 Look at package name when checking whether the shell package can be used (# 142) > f1822b1 Disable Logs/Metrics on GKE and Run Preemptible Nodes (# 138) > 32375dc remove clusteradmin grant (# 141) > 987528e Temporarily fix the unit tests for library.sh (# 143) > da09733 print commit hash (# 140) bumping knative.dev/pkg 77555ea...ca64d3b: > ca64d3b Update community files (# 2404) > 2783cd8 Do not block NotFound error during patching resources (# 2403) > d7b329c 🐛 Update required Go version to 1.17 to fix # 2399 (# 2400) > 3ba5d72 Don't discard addressable resolver original errors (# 2395) Signed-off-by: Knative Automation <automation@knative.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give us early warning of changes in upstream Golang that
may affect us.
Signed-off-by: Jonathan Yu jawnsy@redhat.com